Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue 10611 add copy id feature to Panoramax #10697

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

avijitdas126
Copy link

Changes

  • Added "Copy ID" button/icon to relevant UI components.
  • Implemented clipboard functionality to copy the ID with a single click.

Benefits

  • Improves user experience by simplifying ID retrieval.
  • Aligns Panoramax features with those of Mapillary for consistency.

Reference

Closes #10611

@gedankenstuecke
Copy link

While not being a maintainer, I don't think this actually closes what the maintainers suggested to be the solution in #10611 as the PR as-is leads to a degradation of the workflow for mapillary.

The suggestion was to copy the feature that was introduced for mapillary (c.f. #10611 (comment)), which allows adding the image ID as a new key/value pair to the features, instead of just copying the image ID to the clipboard. Could you try to expand on that mapillary feature to instead make it work for the other image providers too?

@avijitdas126
Copy link
Author

avijitdas126 commented Feb 6, 2025 via email

@gedankenstuecke
Copy link

I don't think you've pushed any changes to this PR yet?

Also: please check that the button for adding images doesn't overlap with existing UI, c.f. the high-res button for panoramax

image

@avijitdas126
Copy link
Author

I'll enhance the UI implementation and introduce the image ID as a new key/value pair to streamline the process.

@tordans
Copy link
Collaborator

tordans commented Feb 6, 2025

Pleas double check the hints that I posted in #10611 (comment) and #10611 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panoramax: Adopt "copy id" feature from mapillary
3 participants