Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panoramax: Adopt "copy id" feature from mapillary #10856

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MohamedAli00949
Copy link

Hi there,

This is my code to add the copy id button at the Panoramax image

Changes

  • "Copy ID" button component.

Issue

Closes #10611

@tordans
Copy link
Collaborator

tordans commented Mar 10, 2025

From reading the code I don't see how this PR could resolve the requirements described in the issue, specifically #10611 (comment) and #10611 (comment)

@MohamedAli00949
Copy link
Author

MohamedAli00949 commented Mar 10, 2025

As I understood the issue, I found the requirements are to add the copy id button to the photo viewer, such as below, and research imagery services such as Panoramax photo viewer. I have replied with the research results.
Screenshot 2025-03-10 111753

So, what is wrong with my implementation? and How to improve it.

Thanks in advanced

@MohamedAli00949
Copy link
Author

@tordans, Do you mean that I haven't used the panoramax=* field and want to use it at the copy button instead of passing it to the function or another thing?

@tyrasd tyrasd added the streetlevel An issue with streetlevel photos label Mar 10, 2025
@MohamedAli00949
Copy link
Author

@tordans, after reading the related modules to this feature, I have found another solution to solving this problem using hash (search hash params class, or using context). Is this suitable?

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should work like the corresponding button on mapillary photos:

image

@MohamedAli00949
Copy link
Author

Ok, But I will use the copy icon instead of the plus

@MohamedAli00949 MohamedAli00949 force-pushed the enh/add-panoramax-copy-id branch from ddfda67 to 366dc0a Compare March 12, 2025 05:22
@MohamedAli00949
Copy link
Author

Hi @tyrasd,
I have changed the component, but the street-side photo viewer appears as the following.
image

I suggest the following style:
image
If my suggestion is good, I will commit these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
streetlevel An issue with streetlevel photos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panoramax: Adopt "copy id" feature from mapillary
3 participants