-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panoramax: Adopt "copy id" feature from mapillary #10856
base: develop
Are you sure you want to change the base?
Panoramax: Adopt "copy id" feature from mapillary #10856
Conversation
From reading the code I don't see how this PR could resolve the requirements described in the issue, specifically #10611 (comment) and #10611 (comment) |
@tordans, Do you mean that I haven't used the |
@tordans, after reading the related modules to this feature, I have found another solution to solving this problem using hash (search hash params class, or using context). Is this suitable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, But I will use the copy icon instead of the plus |
ddfda67
to
366dc0a
Compare
Hi @tyrasd, I suggest the following style: |
Hi there,
This is my code to add the
copy id
button at the Panoramax imageChanges
Issue
Closes #10611