Skip to content

Conversation

rkoeze
Copy link
Contributor

@rkoeze rkoeze commented Oct 20, 2025

Description

The application_controller_renderer.rb file is no longer included in newly generated Rails apps. The rationale:

I don't think this is something most Rails apps will need (certainly not on day 1); users can configure this feature when they need it.

That reasoning applies here too. Let's remove something we don't need. And if we ever do, we can add it back without issue. This change also keeps us aligned with Rails defaults.

How has this been tested?

I was able to build and navigate the app locally. That and the tests pass.

@rkoeze rkoeze changed the title Remove empty file Remove unused initializer Oct 20, 2025
@rkoeze rkoeze force-pushed the rkoeze/remove-empty-initializer branch from 308da27 to 3da8815 Compare October 20, 2025 02:08
Remove unused initializer file that is no longer included by default in new Rails
applications.
@rkoeze rkoeze force-pushed the rkoeze/remove-empty-initializer branch from 3da8815 to 62b605b Compare October 20, 2025 02:18
@rkoeze rkoeze marked this pull request as ready for review October 20, 2025 02:30
@gravitystorm gravitystorm added the dx Developer Experience label Oct 20, 2025
@gravitystorm gravitystorm merged commit 0ed4e68 into openstreetmap:master Oct 20, 2025
12 checks passed
@gravitystorm
Copy link
Collaborator

Merged, thanks!

@rkoeze rkoeze deleted the rkoeze/remove-empty-initializer branch October 20, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dx Developer Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants