Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update docs and pin to java-sdk 0.1.0 #11

Merged
merged 7 commits into from
Jun 13, 2024
Merged

chore: update docs and pin to java-sdk 0.1.0 #11

merged 7 commits into from
Jun 13, 2024

Conversation

ttschampel
Copy link
Member

@ttschampel ttschampel commented Jun 12, 2024 •
edited
Loading

  • update docs for use of GH creds
  • update mermaid markdown usage with mermaid cli
  • depend on upstream java sdk 0.1.0 vs. snapshot (fixes BouncyCastle Runtime Issues)

@ttschampel ttschampel changed the title update doc diagrams chore: update docs Jun 12, 2024
@ttschampel ttschampel changed the title chore: update docs chore: update docs and pull in upstream java-sdk changes Jun 13, 2024
@ttschampel ttschampel marked this pull request as ready for review June 13, 2024 16:05
@ttschampel ttschampel requested review from a team as code owners June 13, 2024 16:05
@ttschampel ttschampel changed the title chore: update docs and pull in upstream java-sdk changes chore: update docs and pin to java-sdk 0.1.0 Jun 13, 2024
mkleene
mkleene approved these changes Jun 13, 2024
View reviewed changes
Copy link

@mkleene mkleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the integration test deletion but everything else looks good

@ttschampel ttschampel merged commit 6484699 into main Jun 13, 2024
3 checks passed
@ttschampel ttschampel deleted the update_figure_gen branch June 13, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkleene mkleene mkleene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttschampel @mkleene