-
Notifications
You must be signed in to change notification settings - Fork 8
chore(core): bump sdk v0.7.0 #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jrschumacher, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a routine maintenance update by bumping the core OpenTDF SDK and protocol definitions to version 0.7.0. In addition to these primary updates, numerous other Go module dependencies have been upgraded to their latest versions. This ensures the project remains current with its underlying libraries, benefiting from performance improvements, bug fixes, and security enhancements.
Highlights
- Core SDK Update: The core OpenTDF platform SDK has been updated to version 0.7.0, bringing in the latest features and fixes from the SDK.
- Protocol Definitions Update: The OpenTDF protocol definitions for Go have been bumped to version 0.7.0, ensuring compatibility with the updated SDK.
- General Dependency Updates: Several other indirect and direct Go module dependencies have been updated to their latest stable versions, including various golang.org/x packages, Google gRPC and Protobuf libraries, and other third-party modules. This ensures the project benefits from the latest improvements and security patches.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several dependencies, most notably bumping the OpenTDF SDK and protocol libraries to v0.7.0. The changes are straightforward dependency version bumps in go.mod and go.sum. My main feedback is to run go mod tidy to clean up the dependency files, as it seems some old, unused dependency checksums are still present in go.sum.
| github.com/opentdf/platform/protocol/go v0.7.0 | ||
| github.com/opentdf/platform/sdk v0.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that go mod tidy was not run after updating the dependencies. The go.sum file contains entries for old dependency versions that are no longer listed in go.mod. Running go mod tidy will clean up these unused entries and ensure the dependency files are minimal and consistent.
For example, go.sum contains entries for both github.com/Masterminds/semver/v3 v3.3.1 and v3.4.0, while go.mod only lists v3.4.0 as an indirect dependency.
Please run go mod tidy to clean up the go.mod and go.sum files.
No description provided.