-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): public client and other enhancements to well-known SDK functionality #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
commented
Aug 16, 2024
jakedoublev
commented
Aug 16, 2024
Cannot deprecate |
jrschumacher
requested changes
Aug 19, 2024
0e6d01e
to
3371f23
Compare
3fb3dab
to
45130df
Compare
Work on this uncovered #1384 |
8d44665
to
2d86af3
Compare
2d86af3
to
b729e00
Compare
jrschumacher
approved these changes
Aug 19, 2024
This was referenced Aug 19, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.8](sdk/v0.3.7...sdk/v0.3.8) (2024-08-19) ### Features * **sdk:** public client and other enhancements to well-known SDK functionality ([#1365](#1365)) ([3be50a4](3be50a4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.19](service/v0.4.18...service/v0.4.19) (2024-08-20) ### Features * **core:** add RPCs to namespaces service to handle assignment/removal of KAS grants ([#1344](#1344)) ([ee47d6c](ee47d6c)) * **core:** Adds key ids to kas registry ([#1347](#1347)) ([e6c76ee](e6c76ee)) * **core:** further support in policy for namespace grants ([#1334](#1334)) ([d56231e](d56231e)) * **core:** support grants to namespaces, definitions, and values in GetAttributeByValueFqns ([#1353](#1353)) ([42a3d74](42a3d74)) * **core:** validate kas uri ([#1351](#1351)) ([2b70931](2b70931)) * **policy:** 1277 protos and service methods for Resource Mapping Groups operations ([#1343](#1343)) ([570f402](570f402)) * **sdk:** Load KAS keys from policy service ([#1346](#1346)) ([fe628a0](fe628a0)) * **sdk:** public client and other enhancements to well-known SDK functionality ([#1365](#1365)) ([3be50a4](3be50a4)) ### Bug Fixes * **authz:** Add http routes for authorization to casbin policy ([#1355](#1355)) ([3fbaf59](3fbaf59)) * **core:** align keycloak provisioning in one command ([#1381](#1381)) ([c3611d2](c3611d2)), closes [#1380](#1380) * **core:** align policy kas grant assignments http gateway methods with actions ([#1299](#1299)) ([031c6ca](031c6ca)) * **core:** Autobump service ([#1340](#1340)) ([3414670](3414670)) * **core:** Autobump service ([#1369](#1369)) ([2ac2378](2ac2378)) * **core:** Autobump service ([#1403](#1403)) ([8084e3e](8084e3e)) * **core:** Autobump service ([#1405](#1405)) ([74a7f0c](74a7f0c)) * **core:** bump go version to 1.22 ([#1407](#1407)) ([c696cd1](c696cd1)) * **core:** cleanup sensitive info being logged from configuration ([#1366](#1366)) ([2b6cf62](2b6cf62)) * **core:** policy kas grants list (filter params and namespace grants) ([#1342](#1342)) ([f18ba68](f18ba68)) * **core:** policy migrations timestamps merge order ([#1325](#1325)) ([2bf4290](2bf4290)) * **sdk:** align sdk with platform modes ([#1328](#1328)) ([88ca6f7](88ca6f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1373
This PR makes the following changes:
http://localhost:9000
to supportotdfctl
idP
accessor methods to the SDK for reading the well-known configuration of the platform pre-authpublic_client_id
to the well-known idP config (with example configs updated) and a warning log about discovery if not provided in the config on startupplatform_issuer
as a top-level well-known config key that is a duplicate ofidp.issuer
because of this issue sdk should retrieve platform issuer from well-known idp.issuer instead of platform_issuer java-sdk#119