-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add otelto opentdf services #1858
Open
sujankota
wants to merge
30
commits into
main
Choose a base branch
from
feat/add-otel-to-service
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+271
−70
Open
Changes from 3 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
6e8a078
feat(core): add otelto opentdf services
sujankota 61adb72
more changes
sujankota 2a93192
more traces
sujankota 34e7bee
add code to push traces
sujankota daf8b85
cleanup
sujankota f0ea802
Update the docker compose
sujankota b284880
Merge branch 'main' into feat/add-otel-to-service
sujankota bfcdc0e
fix the go.mod file
sujankota ef5f004
fix lint error
sujankota 538aab5
Fix the go.mod
sujankota 1249aac
Merge branch 'main' into feat/add-otel-to-service
sujankota 96e7ae2
Merge branch 'main' into feat/add-otel-to-service
sujankota 1e70449
fix lint errors
sujankota e61045b
Fix the unittests
sujankota 1fc4c01
Merge branch 'main' into feat/add-otel-to-service
sujankota 201a996
fix lint issues
sujankota 5c029e5
fix unittests
sujankota a46a397
Fix the build'
sujankota bdd13e4
Fix the build
sujankota bfca207
Fix the build
sujankota 0e6f0e6
Fix the build
sujankota d028b36
fix build
sujankota 67ea89e
fix build
sujankota edb1490
fix the build
sujankota d67db7b
Update go.sum
dmihalcik-virtru 1530e6b
updates to go 1.22.11
dmihalcik-virtru 2595bce
Merge branch 'main' into feat/add-otel-to-service
sujankota a09f6a6
Address code review comments
sujankota 1abfeb5
fix lint error
sujankota b444eec
Merge branch 'main' into feat/add-otel-to-service
sujankota File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking we might want to create some type of metrics / tracing package that we could use to abstract away a lot of these
if as.Tracer != nil
checksThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have a tracing package so we can probably add it there.