Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): EXPERIMENTAL: EC-wrapped key support #1902

Merged
merged 16 commits into from
Feb 14, 2025
Merged

feat(core): EXPERIMENTAL: EC-wrapped key support #1902

merged 16 commits into from
Feb 14, 2025
+1,146 −297

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Feb 3, 2025 •
edited
Loading

Proposed Changes

  • Lets KAS use an elliptic key based mechanism for key (split) encapsulation
  • Adds a new ec-wrapped KAO type that uses a hybrid EC encryption scheme to wrap the values
  • Adds a feature flag (services.kas.ec_tdf_enabled) on the server.
  • Exposes feature flag to service launcher workflows as ec-tdf-enabled
  • To use with SDK, adds a new WithWrappingKeyAlg functional option

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@dmihalcik-virtru
feat(core): Lets KAS use EC for TDF wraps
2a794b4 
- Lets KAS use an elliptic key based mechanism for key (split) encapsulation
@dmihalcik-virtru dmihalcik-virtru changed the title Feature/ecc wrappper feat(core): Adds EC-wrapped key support to KAS Feb 5, 2025
@github-actions github-actions bot mentioned this pull request Feb 6, 2025
Draft
3 tasks
@dmihalcik-virtru dmihalcik-virtru marked this pull request as ready for review February 10, 2025 19:56
@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners February 10, 2025 19:56
@dmihalcik-virtru dmihalcik-virtru changed the title feat(core): Adds EC-wrapped key support to KAS feat(core): EXPERIMENTAL: EC-wrapped key support Feb 14, 2025
@dmihalcik-virtru dmihalcik-virtru added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 652266f Feb 14, 2025
24 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/ecc-wrappper branch February 14, 2025 15:30
This was referenced Feb 14, 2025
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strantalis strantalis strantalis approved these changes

@sujankota sujankota Awaiting requested review from sujankota

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmihalcik-virtru @strantalis @sujankota