fix: Service utilize httputil.SafeHttpClient
#1926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR follows #1910 by updating `service` to utilize the new `httputil` helper for constructing a client which wont follow redirects, and has sensible timeouts. The prior auth API was marked as deprecated. There is no remaining use within this repo, so it may be able to be removed. Merging this should fully resolve #1891.
jentfoo
force-pushed
the
jent/http.Client_handling
branch
from
f6d0965 to
25dede0
Compare
jakedoublev
approved these changes
Mar 5, 2025
dmihalcik-virtru
approved these changes
Mar 5, 2025
This was referenced Mar 5, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.29](sdk/v0.3.28...sdk/v0.3.29) (2025-03-08) ### Bug Fixes * **core:** Autobump sdk ([#1968](#1968)) ([7084061](7084061)) * **core:** Autobump sdk ([#1972](#1972)) ([7258f5d](7258f5d)) * **core:** Updates ec-wrapped to newer salt ([#1961](#1961)) ([0e17968](0e17968)) * Service utilize `httputil.SafeHttpClient` ([#1926](#1926)) ([af32700](af32700)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.40](service/v0.4.39...service/v0.4.40) (2025-03-10) ### Bug Fixes * **core:** Autobump service ([#1970](#1970)) ([c0bbb11](c0bbb11)) * **core:** Autobump service ([#1976](#1976)) ([c79fe0d](c79fe0d)) * **core:** Fixes merge fail in bulk logic ([#1966](#1966)) ([c93bf62](c93bf62)) * **policy:** remove new public keys rpc's ([#1962](#1962)) ([5049bab](5049bab)) * Service utilize `httputil.SafeHttpClient` ([#1926](#1926)) ([af32700](af32700)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR follows #1910 by updating
serviceto utilize the newhttputilhelper for constructing a client which wont follow redirects, and has sensible timeouts. To quote that description:The prior auth API was marked as deprecated. There is no remaining use within this repo, so it may be able to be removed.
Merging this should fully resolve #1891.
Checklist
Testing Instructions