chore(ci): Add govulncheck to checks.yaml #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were only running this in a timed job, to avoid slowing down developers if a new vulnerability is discovered. Let's see if this is really a problem. If this is causing developer pain, we can add an if block to the step that skips it (or makes it non-blocking) on pushes to main, but blocks release PRs.
jentfoo
previously approved these changes
Mar 15, 2025
elizabethhealy
previously approved these changes
Mar 21, 2025
dmihalcik-virtru
dismissed stale reviews from elizabethhealy and jentfoo
via
11e5450
elizabethhealy
approved these changes
Mar 21, 2025
pflynn-virtru
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Testing Instructions