Skip to content

chore(ci): Fix nightlies #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Jun 4, 2025

Proposed Changes

This should fix the error:

Invalid workflow file: .github/workflows/nightly-checks.yaml#L79The workflow is not valid. .github/workflows/nightly-checks.yaml (Line: 79, Col: 3): Error calling workflow 'opentdf/platform/.github/workflows/checks.yaml@main'. The nested job 'go' is requesting 'checks: write, pull-requests: read', but is only allowed 'checks: none, pull-requests: none'. .github/workflows/nightly-checks.yaml (Line: 79, Col: 3): Error calling workflow 'opentdf/platform/.github/workflows/checks.yaml@main'. The nested job 'benchmark' is requesting 'pull-requests: write', but is only allowed 'pull-requests: none'.

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

image

- checks currently can write to PRs, which nightlies can't
- I'm gonna try to be nice and reduce the required permissions in checks. let's see if this works...
@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners June 4, 2025 16:26
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions bot added comp:ci Github Actions Work size/s labels Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 5000
Denied Decision Requests 0
Total Time 479.488753ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 5000
Denied Decision Requests 0
Total Time 291.814494ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 359.99369ms
Throughput 277.78 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 51.976657929s
Average Latency 516.200804ms
Throughput 96.20 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 4936
Failed Requests 64
Concurrent Requests 50
Total Time 42.632284733s
Average Latency 421.658509ms
Throughput 115.78 requests/second

Error Summary:

Error Message Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error
rpc error: code = Internal desc = could not perform access
64 occurrences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:ci Github Actions Work size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant