Skip to content

chore(deps): Bump golang to 1.24.6 #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

chore(deps): Bump golang to 1.24.6 #2618

merged 2 commits into from
Aug 7, 2025

Conversation

c-r33d
Copy link
Contributor

@c-r33d c-r33d commented Aug 7, 2025

Proposed Changes

1.) Bump toolchain to v1.24.6 to fix https://pkg.go.dev/vuln/GO-2025-3849

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@c-r33d c-r33d requested review from a team as code owners August 7, 2025 16:34
@github-actions github-actions bot added comp:sdk A software development kit, including library, for client applications and inter-service communicati comp:examples comp:lib:fixtures comp:lib:ocrypto size/s labels Aug 7, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @c-r33d, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the Go toolchain version across several modules in the repository to 1.24.6. This update is a maintenance task aimed at addressing a recently identified vulnerability (GO-2025-3849) and ensuring our dependencies are up-to-date.

Highlights

  • Go Toolchain Update: The Go toolchain version has been bumped from go1.24.4 to go1.24.6 in multiple go.mod files.
  • Security Fix: This update specifically addresses the vulnerability identified as GO-2025-3849.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Go modules align,New toolchain, bugs take their flight,Code now stands secure.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go toolchain from go1.24.4 to go1.24.6 across multiple go.mod files to address a security vulnerability. While the changes made are correct, there is a critical oversight. The go.work file in the repository root also defines a toolchain version and has not been updated from go1.24.4. As detailed in the review comment, this will cause developers using the Go workspace to continue using the vulnerable toolchain, negating the effect of this security fix. It is crucial to update the go.work file as well to fully remediate the vulnerability.

Copy link
Contributor

github-actions bot commented Aug 7, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 176.622787ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 98.612425ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 343.724384ms
Throughput 290.93 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 37.002286826s
Average Latency 367.042973ms
Throughput 135.13 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.677646532s
Average Latency 255.740938ms
Throughput 194.72 requests/second

Copy link
Contributor

github-actions bot commented Aug 7, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 186.801563ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 89.742822ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 359.175609ms
Throughput 278.42 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 39.769164379s
Average Latency 395.981158ms
Throughput 125.73 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 27.039638894s
Average Latency 269.437021ms
Throughput 184.91 requests/second

@c-r33d c-r33d added this pull request to the merge queue Aug 7, 2025
Merged via the queue into main with commit 3843f2b Aug 7, 2025
32 checks passed
@c-r33d c-r33d deleted the chore/bump-golang-version branch August 7, 2025 18:42
@c-r33d
Copy link
Contributor Author

c-r33d commented Aug 11, 2025

/backport

opentdf-automation bot pushed a commit that referenced this pull request Aug 11, 2025
### Proposed Changes

1.) Bump toolchain to v1.24.6 to fix
https://pkg.go.dev/vuln/GO-2025-3849

### Checklist

- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [ ] I have added or updated documentation

### Testing Instructions

(cherry picked from commit 3843f2b)
@opentdf-automation
Copy link
Contributor

Successfully created backport PR for release/service/v0.8:

opentdf-automation bot added a commit that referenced this pull request Aug 11, 2025
### Proposed Changes

1.) Bump toolchain to v1.24.6 to fix
https://pkg.go.dev/vuln/GO-2025-3849

### Checklist

- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [ ] I have added or updated documentation

### Testing Instructions

(cherry picked from commit 3843f2b)
c-r33d pushed a commit that referenced this pull request Aug 12, 2025
…#2629)

# Description
Backport of #2618 to `release/service/v0.8`.

---------

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Co-authored-by: Dave Mihalcik <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/service/v0.8 comp:examples comp:lib:fixtures comp:lib:ocrypto comp:sdk A software development kit, including library, for client applications and inter-service communicati size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants