-
Notifications
You must be signed in to change notification settings - Fork 19
chore(deps): Bump golang to 1.24.6 #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @c-r33d, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the Go toolchain version across several modules in the repository to 1.24.6. This update is a maintenance task aimed at addressing a recently identified vulnerability (GO-2025-3849) and ensuring our dependencies are up-to-date.
Highlights
- Go Toolchain Update: The Go toolchain version has been bumped from go1.24.4 to go1.24.6 in multiple go.mod files.
- Security Fix: This update specifically addresses the vulnerability identified as GO-2025-3849.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Go modules align,New toolchain, bugs take their flight,Code now stands secure.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Go toolchain from go1.24.4
to go1.24.6
across multiple go.mod
files to address a security vulnerability. While the changes made are correct, there is a critical oversight. The go.work
file in the repository root also defines a toolchain version and has not been updated from go1.24.4
. As detailed in the review comment, this will cause developers using the Go workspace to continue using the vulnerable toolchain, negating the effect of this security fix. It is crucial to update the go.work
file as well to fully remediate the vulnerability.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
/backport |
### Proposed Changes 1.) Bump toolchain to v1.24.6 to fix https://pkg.go.dev/vuln/GO-2025-3849 ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions (cherry picked from commit 3843f2b)
Successfully created backport PR for |
### Proposed Changes 1.) Bump toolchain to v1.24.6 to fix https://pkg.go.dev/vuln/GO-2025-3849 ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions (cherry picked from commit 3843f2b)
…#2629) # Description Backport of #2618 to `release/service/v0.8`. --------- Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: Dave Mihalcik <[email protected]> Co-authored-by: Copilot <[email protected]>
Proposed Changes
1.) Bump toolchain to v1.24.6 to fix https://pkg.go.dev/vuln/GO-2025-3849
Checklist
Testing Instructions