Skip to content

feat(deps): Bump proto go to v0.7.0 #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

c-r33d
Copy link
Contributor

@c-r33d c-r33d commented Aug 11, 2025

Proposed Changes

1.) Bump proto/go in service/sdk to v0.7.0

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@c-r33d c-r33d requested review from a team as code owners August 11, 2025 13:59
@github-actions github-actions bot added the comp:sdk A software development kit, including library, for client applications and inter-service communicati label Aug 11, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @c-r33d, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine dependency update. I've bumped the protocol/go dependency to its latest v0.7.0 version across both the sdk and service modules. This ensures that both components are aligned with the most recent protocol definitions, which is crucial for maintaining compatibility and leveraging any new features or fixes introduced in the updated protocol.

Highlights

  • SDK Protocol Dependency Update: I've updated the github.com/opentdf/platform/protocol/go dependency from version v0.6.2 to v0.7.0 in the sdk/go.mod file.
  • Service Protocol Dependency Update: I've also updated the github.com/opentdf/platform/protocol/go dependency from version v0.6.2 to v0.7.0 in the service/go.mod file.
  • Checksum Updates: Corresponding go.sum files in both sdk and service directories have been updated to reflect the new checksums for the v0.7.0 protocol dependency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


New version arrives, Dependencies now align, Code flows smooth and free.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the github.com/opentdf/platform/protocol/go dependency from v0.6.2 to v0.7.0 in both the sdk and service modules. The changes are confined to go.mod and go.sum files and appear to be correct. Based on the provided changelog, this version bump introduces new features without any specified breaking changes. The update is consistent across both modules.

Copy link
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 175.66072ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 125.096954ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 354.249992ms
Throughput 282.29 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 36.494810109s
Average Latency 362.392207ms
Throughput 137.01 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 24.943154622s
Average Latency 248.228236ms
Throughput 200.46 requests/second

@c-r33d c-r33d enabled auto-merge August 11, 2025 14:17
@c-r33d c-r33d added this pull request to the merge queue Aug 11, 2025
@c-r33d c-r33d removed this pull request from the merge queue due to a manual request Aug 11, 2025
@dmihalcik-virtru
Copy link
Member

@c-r33d : To run dependabot manually, so you don't need another reviewer, you can go to insights > dependency graph > dependabot, then select which go.mod you want updated, click 'recent update jobs' on its entry, then press the 'check for updates' button.

#2627

@c-r33d
Copy link
Contributor Author

c-r33d commented Aug 11, 2025

@c-r33d : To run dependabot manually, so you don't need another reviewer, you can go to insights > dependency graph > dependabot, then select which go.mod you want updated, click 'recent update jobs' on its entry, then press the 'check for updates' button.

#2627

Ah, yes. Thanks @dmihalcik-virtru; I always forget about dependabot.

@c-r33d c-r33d closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:sdk A software development kit, including library, for client applications and inter-service communicati size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants