-
Notifications
You must be signed in to change notification settings - Fork 19
feat(deps): Bump proto go to v0.7.0 #2626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @c-r33d, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a routine dependency update. I've bumped the protocol/go
dependency to its latest v0.7.0
version across both the sdk
and service
modules. This ensures that both components are aligned with the most recent protocol definitions, which is crucial for maintaining compatibility and leveraging any new features or fixes introduced in the updated protocol.
Highlights
- SDK Protocol Dependency Update: I've updated the
github.com/opentdf/platform/protocol/go
dependency from versionv0.6.2
tov0.7.0
in thesdk/go.mod
file. - Service Protocol Dependency Update: I've also updated the
github.com/opentdf/platform/protocol/go
dependency from versionv0.6.2
tov0.7.0
in theservice/go.mod
file. - Checksum Updates: Corresponding
go.sum
files in bothsdk
andservice
directories have been updated to reflect the new checksums for thev0.7.0
protocol dependency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
New version arrives, Dependencies now align, Code flows smooth and free.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the github.com/opentdf/platform/protocol/go
dependency from v0.6.2
to v0.7.0
in both the sdk
and service
modules. The changes are confined to go.mod
and go.sum
files and appear to be correct. Based on the provided changelog, this version bump introduces new features without any specified breaking changes. The update is consistent across both modules.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Ah, yes. Thanks @dmihalcik-virtru; I always forget about dependabot. |
Proposed Changes
1.) Bump proto/go in service/sdk to v0.7.0
Checklist
Testing Instructions