Skip to content

chore(ci): Fixes for checks for buf and go mods #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

dmihalcik-virtru
Copy link
Member

Proposed Changes

  • For buf breaking, the base should be the pull request target, on pull requests
  • For go mod replace directive checks, check all release please branches, not just main ones

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

- For buf breaking, the base should be the pull request target, on pull requests
- For go mod replace directive checks, check all release please branches, not just main ones
@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners August 12, 2025 12:27
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions bot added comp:ci Github Actions Work size/xs labels Aug 12, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CI workflow checks for buf breaking changes and Go module replace directives. The changes ensure proper base branch references for pull request validation and extend coverage to all release branches.

  • Updates buf breaking action to use pull request base branch instead of hardcoded main
  • Expands release branch pattern matching for Go mod replace directive checks
  • Adds release/** branches to workflow triggers

Copy link
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 187.890891ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 102.388074ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 361.134301ms
Throughput 276.91 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 38.213975276s
Average Latency 379.551174ms
Throughput 130.84 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.895704631s
Average Latency 258.032239ms
Throughput 193.08 requests/second

Copy link
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 175.766467ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 93.644359ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 339.205821ms
Throughput 294.81 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 36.684067225s
Average Latency 364.949639ms
Throughput 136.30 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.563919201s
Average Latency 254.605176ms
Throughput 195.59 requests/second

@c-r33d c-r33d added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit c52bc15 Aug 12, 2025
33 of 34 checks passed
@c-r33d c-r33d deleted the DSPX-1568-fix-breaking-checks branch August 12, 2025 15:55
@c-r33d
Copy link
Contributor

c-r33d commented Aug 12, 2025

/backport

c-r33d pushed a commit that referenced this pull request Aug 12, 2025
### Proposed Changes

- For buf breaking, the base should be the pull request target, on pull
requests
- For go mod replace directive checks, check all release please
branches, not just main ones

### Checklist

- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [ ] I have added or updated documentation

### Testing Instructions

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants