-
Notifications
You must be signed in to change notification settings - Fork 19
chore(ci): Fixes for checks for buf and go mods #2633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- For buf breaking, the base should be the pull request target, on pull requests - For go mod replace directive checks, check all release please branches, not just main ones
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes CI workflow checks for buf breaking changes and Go module replace directives. The changes ensure proper base branch references for pull request validation and extend coverage to all release branches.
- Updates buf breaking action to use pull request base branch instead of hardcoded main
- Expands release branch pattern matching for Go mod replace directive checks
- Adds release/** branches to workflow triggers
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Co-authored-by: Copilot <[email protected]>
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
/backport |
### Proposed Changes - For buf breaking, the base should be the pull request target, on pull requests - For go mod replace directive checks, check all release please branches, not just main ones ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions --------- Co-authored-by: Copilot <[email protected]>
Proposed Changes
Checklist
Testing Instructions