Skip to content

chore(docs): Fix changelog #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

c-r33d
Copy link
Contributor

@c-r33d c-r33d commented Aug 18, 2025

Proposed Changes

1.) SDK release v0.7 changelog had additional features/bugs that were fixed in previous releases.

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@c-r33d c-r33d requested review from a team as code owners August 18, 2025 20:50
@github-actions github-actions bot added comp:ci Github Actions Work comp:sdk A software development kit, including library, for client applications and inter-service communicati labels Aug 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @c-r33d, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a chore to fix the SDK v0.7 changelog. The primary goal is to ensure the changelog accurately reflects the features and bug fixes included in the SDK's 0.7.0 release. This involves updating version numbers across relevant configuration and source files, and explicitly documenting dependency updates within the changelog itself.

Highlights

  • Release Manifest Update: The 'sdk' version in the release-please manifest was incremented from '0.6.1' to '0.7.0'.
  • Changelog Entry for SDK v0.7.0: A new entry for version '0.7.0' was added to the SDK's changelog, detailing dependency updates for Docker and the internal 'protocol/go' module.
  • SDK Version Constant Update: The internal version constant in 'sdk/version.go' was synchronized to '0.7.0', aligning it with the new release.
  • New Release Manifest File: A new '.release-please-manifest.json' file was introduced, containing initial versioning for several components.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Versions advance, Changelog tells what is new, Code evolves on.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@c-r33d c-r33d changed the base branch from main to release-please--branches--main--components--sdk August 18, 2025 20:51
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the changelog for the SDK v0.7.0 release. The changes correctly update the version in sdk/version.go and .github/release-please/release-please-manifest.json, and clean up the sdk/CHANGELOG.md. However, a new manifest file, .release-please-manifest.json, has been added to the root of the repository. This file contains outdated version information and seems to have been added by mistake. It should be removed to avoid potential issues with the release process.

Copy link
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 183.256778ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 95.862376ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 353.417148ms
Throughput 282.95 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 39.007644487s
Average Latency 388.443831ms
Throughput 128.18 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 26.416722522s
Average Latency 263.125932ms
Throughput 189.27 requests/second

Copy link
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 175.844506ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 96.709204ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 349.107996ms
Throughput 286.44 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 36.330581346s
Average Latency 361.188111ms
Throughput 137.63 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.298901539s
Average Latency 252.191284ms
Throughput 197.64 requests/second

@opentdf-automation opentdf-automation bot force-pushed the release-please--branches--main--components--sdk branch from 393ae17 to fa5d134 Compare August 19, 2025 15:56
alkalescent
alkalescent previously approved these changes Aug 19, 2025
…hub.com:opentdf/platform into fix-changlog-sdk-v07
@policy-bot-opentdf policy-bot-opentdf bot dismissed alkalescent’s stale review August 19, 2025 16:06

Invalidated by push of 4125e8e

Copy link
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 172.89566ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 98.686203ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 339.543868ms
Throughput 294.51 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 36.267927351s
Average Latency 361.461073ms
Throughput 137.86 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.57413064s
Average Latency 255.0139ms
Throughput 195.51 requests/second

@c-r33d c-r33d merged commit bbf59c3 into release-please--branches--main--components--sdk Aug 19, 2025
23 of 24 checks passed
@c-r33d c-r33d deleted the fix-changlog-sdk-v07 branch August 19, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:ci Github Actions Work comp:sdk A software development kit, including library, for client applications and inter-service communicati size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants