-
Notifications
You must be signed in to change notification settings - Fork 24
feat(core): DSPX-2126 simplify docker compose UX
#2958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
b-long
wants to merge
12
commits into
main
Choose a base branch
from
chore/DSPX-2126--docker-compose
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
45bb685
feat(core): tweak docker-compose to allow a self-contained UX
b-long 48927ec
feat(core): tweak Consuming.md, to use self-contained docker-compose UX
b-long fe8a1df
feat(core): tweak Consuming.md, to use self-contained docker-compose UX
b-long dc25a60
remove 'go' reference, no longer needed
b-long 557851f
distinguish consumer and default compose files
b-long 3c0effb
update docs/Consuming.md
b-long 2c3fe64
DRY compose files & consolidate using "extends:"
b-long bf8222e
feat(core): tweak docker-compose to allow a self-contained UX
b-long 18375ee
feat(core): tweak Consuming.md, to use self-contained docker-compose UX
b-long e2d734d
feat(core): tweak Consuming.md, to use self-contained docker-compose UX
b-long 698197e
feat(core): tweak Consuming.md, to use self-contained docker-compose UX
b-long 7e2705c
feat(core): tweak Consuming.md, to use self-contained docker-compose UX
b-long File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
docker-compose.yamlfile usesextendsto inherit service configurations fromdocker-compose.base.yaml, which is great for reducing duplication. However, top-level keys likenetworksandvolumesare not inherited viaextends. This means that runningdocker compose upwith just this file will fail or not work as intended because theopentdf_platformnetwork and theers_*volumes are not defined.To fix this, you can use the
includedirective (available in Compose v2.20+) at the top of this file to properly include the base configuration:Alternatively, you would need to instruct developers to always use
docker compose -f docker-compose.yaml -f docker-compose.base.yaml up, which is less convenient.