chore(xtest): Add nano plaintext policy coverage #327
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces comprehensive test coverage for the "plaintext policy mode" feature within the nano TDF container. It updates the testing framework to properly configure and execute encryption operations with this new policy mode across different SDKs (Go, Java, JavaScript) and adds a dedicated test case to validate its behavior.
Highlights
- SDK Test Script Updates: Modified
cli.shscripts for Go, Java, and JavaScript SDKs to recognize and support thenano_policymode_plaintextfeature. This includes adding the necessary command-line arguments (--policy-mode plaintextor--policy-type plaintext) when the plaintext policy is enabled for encryption. - Python Test Framework Integration: Updated
xtest/tdfs.pyto expose thepolicy_modeoption in theencrypthelper function, allowing tests to explicitly request plaintext policy encryption by setting theXT_WITH_PLAINTEXT_POLICYenvironment variable. - New Test Case for Plaintext Policy: Introduced
test_container_policy_modeinxtest/test_policytypes.pyto specifically validate the functionality of plaintext policy mode fornanocontainers, including checks on the TDF header's policy type, asserting it remainsEMBEDDED.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request adds test coverage for the nano TDF plaintext policy mode. There's a bug in the Java SDK's test script that will prevent it from running, and the new Python test for the plaintext policy mode doesn't actually enable the feature it's meant to test. I've also pointed out a logic bug in how the new feature is enabled in the Python test framework and a minor code duplication issue.
|
| """ | ||
| if container not in {"nano", "nano-with-ecdsa"}: | ||
| pytest.skip(f"Container {container} does not support plaintext policy mode") | ||
| if not encrypt_sdk.supports("nano_policymode_plaintext"): |
There was a problem hiding this comment.
does the decrypt sdk also need to support plaintext policy?
Currently always skipped since not implemented