fix: identifier type extraction from protocol #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the bit masking operation on the protocol variable to directly use its value for determining the identifier type. This simplification potentially fixes any errors induced by incorrect bit manipulation of the protocol field.
|
huh the reason it currently works is because we are setting the this.protocol to be the combined value with the identifier included. This is one of several surprising things which I've removed in #338 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the bit masking operation on the protocol variable to directly use its value for determining the identifier type. This simplification potentially fixes any errors induced by incorrect bit manipulation of the protocol field.