fix(ci): use 'sdk' scope in release-please PR title pattern#867
fix(ci): use 'sdk' scope in release-please PR title pattern#867pflynn-virtru wants to merge 1 commit intomainfrom
Conversation
The previous pattern used ${branch} as the scope, generating titles like
`chore(main): release sdk 0.11.0` which fail the conventional commit
check since 'main' is not an allowed scope.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical CI issue by updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a failing conventional commit check for release PRs by changing the group-pull-request-title-pattern in the release-please configurations. The change replaces the dynamic ${branch} variable with the hardcoded scope sdk, which is the correct component scope. The change is sound and addresses the issue. I've added a couple of medium-severity comments regarding the duplication of the component name, which introduces a minor maintainability concern to be aware of for the future.
| "bump-minor-pre-major": true, | ||
| "versioning": "always-bump-minor", | ||
| "group-pull-request-title-pattern": "chore(${branch}): release ${version}", | ||
| "group-pull-request-title-pattern": "chore(sdk): release ${version}", |
There was a problem hiding this comment.
By hardcoding sdk here, you are creating a duplication of the component name, which is also defined under packages...component on line 8. This means if the component name ever changes, it will need to be updated in two places. This could lead to future maintenance issues if not managed carefully.
While this is a reasonable workaround given the limitations of release-please (which doesn't appear to support a component variable in this context), it's important for the team to be aware of this coupling.
| "bump-minor-pre-major": true, | ||
| "versioning": "always-bump-patch", | ||
| "group-pull-request-title-pattern": "chore(${branch}): release ${version}", | ||
| "group-pull-request-title-pattern": "chore(sdk): release ${version}", |
There was a problem hiding this comment.
Similar to the other configuration file, hardcoding sdk here creates a duplication of the component name defined on line 8. This introduces a coupling that could lead to maintenance issues if the component name changes in the future.
marythought
left a comment
marythought
left a comment
There was a problem hiding this comment.
I see Gemini's feedback and I think it's fine
2 participants
Summary
group-pull-request-title-patternfromchore(${branch}): release ${version}tochore(sdk): release ${version}in both config files${branch}variable producesmainas the scope, which isn't in the allowed CCC scopes list, causing the conventional commit check to fail on release PRsTest plan
chore(sdk): release ...as the title, which passes CCC🤖 Generated with Claude Code