fix(ci): update tests to cover sdk-v* tag format for npm latest dist-tag#868
Open
marythought wants to merge 1 commit intomainfrom
Open
fix(ci): update tests to cover sdk-v* tag format for npm latest dist-tag#868marythought wants to merge 1 commit intomainfrom
marythought wants to merge 1 commit intomainfrom
Conversation
Release Please changed the tag format from sdk/v* to sdk-v* starting at v0.4.1. The scripts already handle both formats, but the tests only covered the old sdk/v* pattern. This adds test coverage for sdk-v* and updates the gh-semver.sh comment to reflect the current format. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdk-v*tag format inguess-dist-tag.batsandgh-semver.bats(the scripts already handle bothsdk/v*andsdk-v*, but tests only covered the old format)gh-semver.shto reflect the currentsdk-v*tag formatsdk/v*tests as "legacy" to ensure backward compatibilityContext
Release Please changed the tag format from
sdk/v*(slash) tosdk-v*(hyphen) starting at v0.4.1 (July 2025). The delivery scripts already match both patterns, but tests only validated the old format. npm'slatestdist-tag has been stuck at 0.4.0 for ~9 months as a result of earlier issues with this mismatch.Test plan
bats .github/workflows/guess-dist-tag.bats .github/workflows/gh-semver.bats)GITHUB_REF=refs/tags/sdk-v0.11.0 .github/workflows/guess-dist-tag.shoutputslatestlatestdist-tag updates on npm🤖 Generated with Claude Code