[bootstrap] conditionally install libavahi-client / libavahi-dev

[jwhui]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @jwhui, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the bootstrap script to make the installation of Avahi client libraries conditional, aligning their installation with the avahi-daemon based on specific environment variables. This change aims to optimize the bootstrap process by only installing these dependencies when they are truly needed, reducing unnecessary package installations for environments that do not require Avahi.

Highlights

• Conditional Avahi Client Libraries Installation: I've refactored the script/bootstrap to ensure that libavahi-client3 and libavahi-client-dev are only installed when the OTBR_MDNS is set to 'avahi', or for CI/reference device builds, matching the existing conditional logic for avahi-daemon.
• Removed libavahi-common-dev: I've removed the unconditional installation of libavahi-common-dev from the bootstrap script, as it was not moved into the conditional block with the other Avahi client libraries.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[jwhui]

/gemini review

[Copilot]

Pull Request Overview

This PR optimizes the installation of Avahi libraries in the bootstrap script by conditionally installing libavahi-client and libavahi-dev packages only when needed, rather than installing them unconditionally.

• Removes unconditional installation of Avahi client libraries
• Moves Avahi library installation inside the conditional block that checks for specific use cases

[gemini-code-assist]

Code Review

This pull request correctly refactors the script/bootstrap to conditionally install Avahi client libraries and development packages, which is a good improvement for efficiency. My review includes one suggestion to improve the readability of the updated apt-get command, making it consistent with the formatting of other package installation commands in the file.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.26%. Comparing base (2b41187) to head (fde21ec).
⚠️ Report is 1164 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2980       +/-   ##
===========================================
- Coverage   55.77%   43.26%   -12.52%     
===========================================
  Files          87      116       +29     
  Lines        6890    14063     +7173     
  Branches        0      961      +961     
===========================================
+ Hits         3843     6084     +2241     
- Misses       3047     7661     +4614     
- Partials        0      318      +318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.