[format] upgrade clang-format to 19 #2990
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Irving-cl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the project's code formatting tool, clang-format, from version 16 to version 19. This change was necessary because clang-format 16 was recently deprecated. The goal is to ensure we are using a current and supported version for maintaining consistent code style across the codebase. This update primarily involves adjusting version references in documentation and scripts, and applying the resulting formatting changes to various C++ source files.
Highlights
- Documentation Updates: Updated the required clang-format version from 16.0.0 to 19.1.7 in both CONTRIBUTING.md and STYLE_GUIDE.md, along with their respective links.
- Script Configuration: Modified the script/clang-format to reflect the new major version 19 and full version 19.1.7, ensuring the correct version is enforced.
- Build and Test Environment: Updated the tests/scripts/bootstrap.sh to install clang-format-19, aligning the testing environment with the new formatting standard.
- Code Formatting Adjustments: Applied automatic code reformatting across several C++ source files (src/agent/application.cpp, src/common/code_utils.hpp, src/dbus/server/dbus_agent.cpp, src/dbus/server/dbus_thread_object_rcp.cpp, src/host/posix/udp_proxy.cpp) due to the clang-format version change.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully upgrades the clang-format version from 16 to 19. The changes include updating documentation and scripts to reflect this new version, and re-formatting the C++ source code accordingly. The changes are consistent and well-executed. I have one minor suggestion to improve the maintainability of a shell script.
Irving-cl
force-pushed
the
update_clang_format_19
branch
from
996a028 to
7a52087
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
===========================================
- Coverage 55.77% 12.11% -43.67%
===========================================
Files 87 113 +26
Lines 6890 13297 +6407
Branches 0 905 +905
===========================================
- Hits 3843 1611 -2232
- Misses 3047 11596 +8549
- Partials 0 90 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR updates the clang-format version from 16 to 19.
We just updated the version from 14 to 16. But very unfortunately clang-format-16 was just deprecated recently. So this time we update the version to the latest available one. There are newer releases than 19 (like 20) but as I tested,
sudo apt-get install -y clang-format-19can work while 20 doesn't work.