fix: enforce max item tier in market operations #3731
Merged
+24
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds validation to ensure item tier does not exceed the configured maximum in market offer creation, cancellation, and acceptance. Also updates item tier assignment to use setTier instead of setAttribute. This improves consistency and prevents invalid item upgrades in market transactions.
There was a problem hiding this comment.
Pull Request Overview
This PR enforces maximum item tier validation in market operations to prevent invalid item upgrades. The changes ensure that item tiers don't exceed the configured maximum when creating, canceling, or accepting market offers.
- Adds tier validation against
FORGE_MAX_ITEM_TIERconfiguration in market operations - Replaces
setAttributecalls withsetTiermethod for consistency - Prevents tier assignment on non-upgradeable items
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/io/iomarket.cpp | Updates expired offer processing to use setTier instead of setAttribute |
| src/game/game.cpp | Adds tier validation in market offer creation, cancellation, and acceptance operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Codemaufeito
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to ensure item tier does not exceed the configured maximum in market offer creation, cancellation, and acceptance. Also updates item tier assignment to use setTier instead of setAttribute. This improves consistency and prevents invalid item upgrades in market transactions.