SLF4J support #52
Draft
SLF4J support #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects a logger collision issue when using java-opentimestamps as a code dependency with other projects. The original issue can be found at opentimestamps#34 and opentimestamps#48.
|
Isn't java.util.logging more agnostic so that dependent library could choose which logging implementation do they prefer? Can't we follow @lvaccaro suggestion #48 (comment) remove slf4j from the lib, then maybe use logback/slf4j in the cli profile? |
|
Yep, that's probably a good idea. I'll get this updated to use that in preference to SLF4J. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the conversation over on #48. I have migrated the project from using
java.util.loggingto SLF4J. This should make it easier for those depending on this library to control the logging that is coming out of the library.There are some changes to how the CLI application needs to be built. Now when creating the OtsCli.jar it should be built with
mvn install -P cliwhich will activate the CLI profile. This adds Logback Classic and a basic stdout log appender configuration to the CLI jar. This will allow log messages to be emitted on the command line.All references to
java.util.logginghave now been removed with SLF4J as the preferred approach. Also the tests have a dependency on Logback Classic to ensure that the correct log message is output on one of the tests.Remaining tasks