Adding Prune command #69
Conversation
|
Hi @StefanoFedeli really useful, thank you. Could you explicit the used strategy to choose which attestations to remove? |
| * @param {DetachedTimestampFile[]} detaches - The array of detached file to stamp; input/output parameter. | ||
| * @param {Object} options - The option arguments. Not used yet | ||
| */ | ||
| prune (detaches, options = {}) { |
There was a problem hiding this comment.
I suggest to update the prune prototype in order to take one DetachedTimestampFile at time, instead an array of file (following the PR's code you are just handle 1 file at time).
| const test = require('tape') | ||
| const Calendar = require('../src/calendar.js') | ||
| const Utils = require('../src/utils.js') | ||
| const { URL } = require('url') |
There was a problem hiding this comment.
Maybe it is auto merging stuff that add URL here and in the src/calendar.js file
| * Delete all the leaves which didn't match the height passed | ||
| */ | ||
| discard_attestation (timestamp, heightToKeep) { | ||
| timestamp.getAttestations().forEach(opStamp => { |
There was a problem hiding this comment.
getAttestations() returns a Set of every attestations walking the timestamp tree until the leaf. I think in this case, you need to check only the current attestations as: timestamp.attestations
| let prunable = false | ||
| let maxHead = 0 | ||
|
|
||
| if (detaches.timestamp.getAttestations().length <= 1) { |
There was a problem hiding this comment.
count only BitcoinBlockHeaderAttestation, because usually there is at least one PendingAttestation that shouldn't be counted
| var iter = timestamp.ops.values() | ||
| let res = iter.next() | ||
| while (!res.done) { | ||
| this.discard_attestation(res.value) |
2 participants
First draft of the prune command asked in here, right now the command is pretty poor:
The branch is not meant to be merged as it is but as a starting point to add the new feature.