fix: fix features page style #3161
Conversation
WalkthroughThis pull request makes two changes: first, it updates a class name in a Vue component by replacing Changes
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
examples/sites/tiny-uno/rules/size.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/src/views/features.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses style adjustments on the features page by modifying the class names and updating the size rules. The changes aim to enhance the styling consistency and responsiveness of the page. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -1,6 +1,6 @@ | |||
| <template> | |||
| <div class="ti-p48"> | |||
| <div class="w1000 !mx-auto markdown-body"> | |||
| <div class="ti-mw1000 !mx-auto markdown-body"> | |||
There was a problem hiding this comment.
The class name change from w1000 to ti-mw1000 should be verified to ensure it aligns with the intended design specifications and does not affect layout negatively.
| @@ -18,9 +20,9 @@ export default function builder(option) { | |||
| return { | |||
| rules: [ | |||
| // 高宽， 字体，行高 f12 lh20 w200 h200 box78 | |||
| [/^(w|h)(\d+)$/, ([, attr, num]) => ({ [`${_s[attr]}`]: $t(num) })], | |||
| [/^(w|h|mw|mh)(\d+)$/, ([, attr, num]) => ({ [`${_s[attr]}`]: $t(num) })], | |||
There was a problem hiding this comment.
Ensure that the addition of mw and mh rules does not conflict with existing styles or introduce unexpected behavior in other components.
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/sites/tiny-uno/rules/size.js (1)
36-43: Consider adding shortcuts for max-width/max-height combinations.You've added support for
mwandmhproperties, which is great. Consider extending the shortcuts section to include combinations for these properties, similar to howboxworks for width and height.shortcuts: [ [/^(m|p)x(-?\d+)$/, ([, t, c]) => `${t}l${c} ${t}r${c}`], [/^(m|p)y(-?\d+)$/, ([, t, c]) => `${t}t${c} ${t}b${c}`], [/^(m|p)x-auto$/, ([, t, c]) => `${t}l-auto ${t}r-auto`], [/^(m|p)y-auto$/, ([, t, c]) => `${t}t-auto ${t}b-auto`], [/^box(\d+)$/, ([, w]) => `w${w} h${w}`], + [/^maxbox(\d+)$/, ([, w]) => `mw${w} mh${w}`] ]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
examples/sites/src/views/features.vue(1 hunks)examples/sites/tiny-uno/rules/size.js(2 hunks)
🔇 Additional comments (4)
examples/sites/src/views/features.vue (1)
3-3: Good improvement for responsiveness.Changing from
w1000toti-mw1000is a good practice for responsive design, as using max-width allows the container to adapt better to smaller screens rather than forcing a fixed width.examples/sites/tiny-uno/rules/size.js (3)
8-9: Properly extended size properties.Adding
mw(max-width) andmh(max-height) properties to the shortkey dictionary is a good addition that enhances the utility framework's capabilities for responsive design.
23-23: Correctly updated regex pattern.The regex has been properly updated to accommodate the new max-width and max-height utilities.
25-25: Percentage utilities correctly updated.Good job extending the percentage-based utility pattern to include max-width and max-height.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Style
New Features