Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTofu Installer #1

Merged
21 commits merged into from
Jan 8, 2024
Merged

OpenTofu Installer #1

21 commits merged into from
Jan 8, 2024

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2023

This PR implements the OpenTofu Installer for Powershell/POSIX shells on Windows, Linux, MacOS and hopefully *NIX.

The intention is to support all POSIX compliant shells as well as Powershell on Windows 10 and 11 to install OpenTofu via all documented means on the website.

Copy link

cloudflare-workers-and-pages bot commented Dec 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a248ff5
Status: ✅  Deploy successful!
Preview URL: https://fca7fe76.opentofu-get.pages.dev
Branch Preview URL: https://convenience-script.opentofu-get.pages.dev

View logs

@ghost ghost force-pushed the convenience-script branch 10 times, most recently from ec61188 to 2b0b7b9 Compare December 21, 2023 17:18
@ghost ghost force-pushed the convenience-script branch 8 times, most recently from 55e9273 to abc8ec6 Compare December 23, 2023 10:00
@ghost ghost changed the title Convenience script implementation OpenTofu Installer Jan 4, 2024
@ghost ghost force-pushed the convenience-script branch from a4094c4 to 610d2f4 Compare January 4, 2024 14:17
@ghost ghost marked this pull request as ready for review January 4, 2024 14:17
@ghost ghost force-pushed the convenience-script branch 3 times, most recently from 7cf66a7 to bad9180 Compare January 4, 2024 14:48
Signed-off-by: Janos Bonic <[email protected]>
Co-authored-by: Christian Mesh <[email protected]>
@ghost ghost requested review from RLRabinowitz and a team January 5, 2024 15:01
@Yantrio
Copy link
Member

Yantrio commented Jan 5, 2024

Again, I'm happy with everything but powershell, nice work 👍

Janos Bonic added 5 commits January 5, 2024 16:18
Signed-off-by: Janos Bonic <[email protected]>
Signed-off-by: Janos Bonic <[email protected]>
Signed-off-by: Janos Bonic <[email protected]>
Signed-off-by: Janos Bonic <[email protected]>
Janos Bonic added 4 commits January 5, 2024 18:10
Signed-off-by: Janos Bonic <[email protected]>
Signed-off-by: Janos Bonic <[email protected]>
Signed-off-by: Janos Bonic <[email protected]>
Signed-off-by: Janos Bonic <[email protected]>
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just taken a look at the Powershell install script as per @Yantrio's request.

Looks good overall (although just for the record my Powershell skills are definitely very rusty). I left some comments, but for the most part it's all pretty minor.

src/install-opentofu.ps1 Outdated Show resolved Hide resolved
src/install-opentofu.ps1 Show resolved Hide resolved
src/install-opentofu.ps1 Outdated Show resolved Hide resolved
src/install-opentofu.ps1 Show resolved Hide resolved
src/install-opentofu.ps1 Outdated Show resolved Hide resolved
src/install-opentofu.ps1 Outdated Show resolved Hide resolved
src/install-opentofu.ps1 Outdated Show resolved Hide resolved
src/install-opentofu.ps1 Show resolved Hide resolved
Janos and others added 2 commits January 8, 2024 12:13
Co-authored-by: Adam Connelly <[email protected]>
Co-authored-by: Adam Connelly <[email protected]>
@ghost
Copy link
Author

ghost commented Jan 8, 2024

Thanks for your help @adamconnelly !

@ghost ghost merged commit 91ee7bd into main Jan 8, 2024
95 checks passed
@ghost ghost deleted the convenience-script branch January 8, 2024 16:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace convenience script
5 participants