Skip to content

Renaming and refactoring the other project references #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 15, 2025

Conversation

Gogotchuri
Copy link
Member

@Gogotchuri Gogotchuri commented May 14, 2025

I understand this is a huge PR, but it is broken down into separate commits that are easier to review.
(Most of the additions +2803 are from the auto-generated functions in 1.9.0.go file)
I advise going through this PR commit by commit and checking each one.

Resolves #8

Changes in this PR:

  • Correct hover docs URLs previously referencing hashicorp.io
  • Change the oldest and the newest versions now referencing the actual generated OpenTofu versions returned by the API
  • Rename semantic tokens with tofu-prefix
  • Change the GitHub repository and object references to correct repositories
  • Add deprecations to deprecated backends
  • Rewrite comments referencing Terraform

I will not squash this PR since including separate commits makes more sense.

@Gogotchuri Gogotchuri requested a review from a team as a code owner May 14, 2025 12:48
@Gogotchuri Gogotchuri force-pushed the reference-renaming branch from 1c3f8b7 to c1bddcc Compare May 14, 2025 12:50
@Gogotchuri Gogotchuri force-pushed the reference-renaming branch from c1bddcc to 6096bcf Compare May 14, 2025 12:51
@Gogotchuri Gogotchuri requested a review from diofeher May 14, 2025 13:00
@Gogotchuri Gogotchuri self-assigned this May 14, 2025
Copy link
Contributor

@yottta yottta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The results returned by grep -r "terraform" . | grep -v "terraform_remote_state" | grep -v "_test.go" in this branch seem that to contain only things that are actually required. Could somebody, more knowledgeable than I am, double check this?
Thanks

Copy link
Member

@diofeher diofeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few nitpicks, but aside from those, it looks great. Thanks for the excellent work!

@Gogotchuri
Copy link
Member Author

Gogotchuri commented May 15, 2025

Thanks for the feedback.
We couldn't have missed anything critical here. We need this merged to move forward with tofu-ls and release the first 0.0.1 versions.
This project still needs a lot of refactoring, and additional changes will be implemented after the first release.
I'll merge this. If the issues you pointed out aren't fully covered by the #21, please open additional, more specific ones.

@Gogotchuri Gogotchuri merged commit dbb48ed into main May 15, 2025
4 of 5 checks passed
@Gogotchuri Gogotchuri deleted the reference-renaming branch May 15, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename other project references
3 participants