-
Notifications
You must be signed in to change notification settings - Fork 0
Renaming and refactoring the other project references #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1c3f8b7
to
c1bddcc
Compare
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
Signed-off-by: Ilia Gogotchuri <[email protected]>
c1bddcc
to
6096bcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The results returned by grep -r "terraform" . | grep -v "terraform_remote_state" | grep -v "_test.go"
in this branch seem that to contain only things that are actually required. Could somebody, more knowledgeable than I am, double check this?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few nitpicks, but aside from those, it looks great. Thanks for the excellent work!
Thanks for the feedback. |
I understand this is a huge PR, but it is broken down into separate commits that are easier to review.
(Most of the additions +2803 are from the auto-generated functions in 1.9.0.go file)
I advise going through this PR commit by commit and checking each one.
Resolves #8
Changes in this PR:
I will not squash this PR since including separate commits makes more sense.