Fix legacy namespace and adds HoverURL #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diogenes Fernandes <[email protected]>
yottta
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to opentofu/vscode-opentofu#6
While integrating with
vscode-opentofu, I noticed I understood wrong where DocsLink is used. For the purpose of the work I was doing, I should've been usingHoverURL. This is what is used when hovering the element.Screenshot of integration:
DocsLink is used in another view of VSCode:
This PR fixes another misunderstanding. When provider addresses have namespaces using
hashicorp, they are mostly being treated as LegacyAddresses in our code:https://github.com/opentofu/registry-address/blob/901b9ae4061a6e83e7db96e71b8d7088294930b3/provider.go#L166
So now, if we have any LegacyAddr, we use the namespace as
hashicorpboth on the HoverURL and the DocsLink.