Extract common integration framework for custom span decorator#526
Open
jianshaow wants to merge 1 commit intoopentracing-contrib:masterfrom
Open
Extract common integration framework for custom span decorator#526jianshaow wants to merge 1 commit intoopentracing-contrib:masterfrom
jianshaow wants to merge 1 commit intoopentracing-contrib:masterfrom
Conversation
safris
force-pushed
the
master
branch
2 times, most recently
from
c57752f to
344063a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @safris, as you mentioned that customizing a span decorator has common pattern, I try to extract a framework for similar extension. I just apply it to apach-httpclient, if you think it is the right direction, I will apply it to the rest of rules I enhanced, maybe more.