Skip to content

Remove fare service from Graph #6292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leonardehrenfried
Copy link
Member

Summary

This removes the fare service from the Graph instance and lets Dagger manage it instead.

Unit tests

A few unit tests had to be adjusted.

Bumping the serialization version id

✔️

@leonardehrenfried leonardehrenfried added Technical Debt bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Skip Changelog labels Nov 29, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner November 29, 2024 11:00
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.16%. Comparing base (a5a328b) to head (177f47b).
Report is 34 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...ner/standalone/configure/ConstructApplication.java 0.00% 3 Missing ⚠️
...pentripplanner/ext/fares/configure/FareModule.java 0.00% 2 Missing ⚠️
...n/java/org/opentripplanner/standalone/OTPMain.java 0.00% 2 Missing ⚠️
...pplanner/standalone/configure/LoadApplication.java 0.00% 2 Missing ⚠️
...entripplanner/apis/gtfs/GraphQLRequestContext.java 0.00% 1 Missing ⚠️
...rg/opentripplanner/graph_builder/GraphBuilder.java 0.00% 1 Missing ⚠️
...andalone/configure/ConstructApplicationModule.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6292      +/-   ##
=============================================
- Coverage      71.19%   71.16%   -0.03%     
+ Complexity     18465    18454      -11     
=============================================
  Files           2026     2027       +1     
  Lines          76289    76296       +7     
  Branches        7807     7807              
=============================================
- Hits           54312    54296      -16     
- Misses         19218    19238      +20     
- Partials        2759     2762       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken marked this pull request as draft December 10, 2024 10:34
vpaturet
vpaturet previously approved these changes Jan 13, 2025
@optionsome optionsome removed the request for review from habrahamsson-skanetrafiken February 11, 2025 09:27
auto-merge was automatically disabled February 13, 2025 11:57

Pull request was converted to draft

@t2gran t2gran modified the milestones: 2.7, 2.8 (next release) Mar 12, 2025
@leonardehrenfried leonardehrenfried marked this pull request as ready for review April 6, 2025 19:54
@leonardehrenfried
Copy link
Member Author

@tkalvas @habrahamsson-skanetrafiken I've rebased and reworked this PR and it's now ready for review again.

tkalvas
tkalvas previously approved these changes Apr 9, 2025
@optionsome
Copy link
Member

There are conflicts in this pr. Who was the second reviewer @habrahamsson-skanetrafiken or @vpaturet ?

@leonardehrenfried
Copy link
Member Author

I resolved the conflicts and this is ready for review again.

I believe that Henrik requested that @vpaturet reviews this.

tkalvas
tkalvas previously approved these changes Apr 28, 2025
@leonardehrenfried
Copy link
Member Author

@tkalvas Regrettably I had to resolve some merge conflicts so your review is required again.

@leonardehrenfried leonardehrenfried merged commit 0e2323d into opentripplanner:dev-2.x May 6, 2025
7 checks passed
t2gran pushed a commit that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump serialization id Add this label if you want the serialization id automatically bumped after merging the PR Skip Changelog Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants