-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove fare service from Graph #6292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fare service from Graph #6292
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6292 +/- ##
=============================================
- Coverage 71.19% 71.16% -0.03%
+ Complexity 18465 18454 -11
=============================================
Files 2026 2027 +1
Lines 76289 76296 +7
Branches 7807 7807
=============================================
- Hits 54312 54296 -16
- Misses 19218 19238 +20
- Partials 2759 2762 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
application/src/main/java/org/opentripplanner/standalone/configure/LoadApplication.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/standalone/OTPMain.java
Outdated
Show resolved
Hide resolved
Pull request was converted to draft
@tkalvas @habrahamsson-skanetrafiken I've rebased and reworked this PR and it's now ready for review again. |
There are conflicts in this pr. Who was the second reviewer @habrahamsson-skanetrafiken or @vpaturet ? |
I resolved the conflicts and this is ready for review again. I believe that Henrik requested that @vpaturet reviews this. |
@tkalvas Regrettably I had to resolve some merge conflicts so your review is required again. |
Summary
This removes the fare service from the Graph instance and lets Dagger manage it instead.
Unit tests
A few unit tests had to be adjusted.
Bumping the serialization version id
✔️