Skip to content

Remove old debug UI #6478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025

Conversation

VillePihlava
Copy link
Contributor

@VillePihlava VillePihlava commented Feb 21, 2025

Summary

This PR removes the old debug UI (application/src/client/classic-debug). Debug layers added back temporarily in #6497 were also removed. I also removed and changed some related documentation.

Issue

N/A

Unit tests

N/A

Documentation

I changed doc/user/Troubleshooting-Routing.md and doc/user/Frontends.md to indicate of this change. I did a quick search for more references of the old debug UI but could not find any. However, there might still be some references left in the documentation.

@VillePihlava VillePihlava requested a review from a team as a code owner February 21, 2025 10:10
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.06%. Comparing base (c6b53d1) to head (7a2f1d5).
Report is 9 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6478      +/-   ##
=============================================
+ Coverage      71.04%   71.06%   +0.02%     
- Complexity     18297    18300       +3     
=============================================
  Files           2005     2004       -1     
  Lines          75850    75829      -21     
  Branches        7779     7778       -1     
=============================================
+ Hits           53884    53886       +2     
+ Misses         19221    19200      -21     
+ Partials        2745     2743       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leonardehrenfried
Copy link
Member

You're also deleting the new debug UI and GraphiQL. Both of those we want to keep. :)

Deleting classic-debug is enough.

@VillePihlava
Copy link
Contributor Author

You're also deleting the new debug UI and GraphiQL. Both of those we want to keep. :)

Deleting classic-debug is enough.

My mistake, thanks for pointing this out :D

@optionsome optionsome requested a review from t2gran February 25, 2025 09:37
@optionsome optionsome marked this pull request as draft February 27, 2025 09:37
@optionsome
Copy link
Member

optionsome commented Feb 27, 2025

I converted this to draft since I was informed there still exist some debug layer related instructions for some OSM editors in Finland that haven't been yet updated to be about the new debug UI. Hopefully soon we can get rid of this.

@VillePihlava VillePihlava added the OTP Debug UI The OTP bundled client label Feb 27, 2025
@t2gran t2gran added this to the 2.8 (next release) milestone Mar 12, 2025
@VillePihlava VillePihlava mentioned this pull request Mar 27, 2025
Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few requests for Frontends.md but rather than playing review ping pong let's merge this and I will change it in a follow up.

@VillePihlava VillePihlava merged commit 68b708f into opentripplanner:dev-2.x Apr 22, 2025
7 checks passed
t2gran pushed a commit that referenced this pull request Apr 22, 2025
@VillePihlava VillePihlava deleted the remove-old-debug-ui branch April 22, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTP Debug UI The OTP bundled client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants