Add generalizedCostMaxLimit to page cursor
#6491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optionsome
reviewed
Feb 26, 2025
application/src/test/java/org/opentripplanner/model/plan/paging/cursor/PageCursorTest.java
Outdated
Show resolved
Hide resolved
This is needed when adding new values to the token.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6491 +/- ##
=============================================
+ Coverage 70.18% 70.21% +0.03%
- Complexity 18308 18329 +21
=============================================
Files 2082 2085 +3
Lines 77188 77308 +120
Branches 7828 7840 +12
=============================================
+ Hits 54175 54284 +109
- Misses 20247 20250 +3
- Partials 2766 2774 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eibakke
previously approved these changes
Mar 10, 2025
eibakke
previously approved these changes
Mar 13, 2025
optionsome
previously approved these changes
Mar 14, 2025
There was a problem hiding this comment.
The couple of typos can be fixed in a follow up pr by @VillePihlava for example.
application/src/main/java/org/opentripplanner/framework/token/Token.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Joel Lappalainen <[email protected]>
optionsome
approved these changes
Mar 14, 2025
|
I merged this since @eibakke allready approved and the last commit was just spelling fixes in doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This prepare the page-token to include the generalized-cost-max-limit, so we do not have to do the extra on-street seach when paging.
Issue
Unit tests
Several new tests are added
Documentation
JavaDoc is updated
Changelog
🟥 Exclude
Bumping the serialization version id
Not needed