Skip to content

Fix cost in debug client #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

optionsome
Copy link
Member

Summary

Fixes generalized cost display in the debug client.

Issue

No issue

Unit tests

No tests

Documentation

No

Changelog

Skipped

@optionsome optionsome added Regression This feature is no longer working. OTP Debug UI The OTP bundled client labels Mar 7, 2025
@optionsome optionsome added this to the 2.7 (next release) milestone Mar 7, 2025
@optionsome optionsome requested a review from a team as a code owner March 7, 2025 15:34
@optionsome
Copy link
Member Author

Btw, it feels slightly wrong to use the schema as the source for types. Would it be possible to generate types from the actual queries instead with the libraries we use?

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (9d01118) to head (8ea2c2a).
Report is 38 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6521   +/-   ##
==========================================
  Coverage      70.17%   70.17%           
+ Complexity     18312    18311    -1     
==========================================
  Files           2082     2082           
  Lines          77211    77211           
  Branches        7831     7831           
==========================================
+ Hits           54184    54185    +1     
+ Misses         20257    20256    -1     
  Partials        2770     2770           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@optionsome
Copy link
Member Author

Closing this as #6538 fixes this problem and more.

@optionsome optionsome closed this Mar 14, 2025
auto-merge was automatically disabled March 14, 2025 08:15

Pull request was closed

@optionsome optionsome deleted the fix-debug-cost branch March 14, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTP Debug UI The OTP bundled client Regression This feature is no longer working. Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants