Fix removal of old vehicle positions #6523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6523 +/- ##
=============================================
+ Coverage 70.17% 70.20% +0.03%
- Complexity 18312 18324 +12
=============================================
Files 2082 2085 +3
Lines 77214 77291 +77
Branches 7831 7834 +3
=============================================
+ Hits 54188 54266 +78
+ Misses 20256 20251 -5
- Partials 2770 2774 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
optionsome
reviewed
Mar 11, 2025
| @@ -13,15 +14,8 @@ public interface RealtimeVehicleRepository { | |||
| * This means that if there are two updaters providing vehicles for the same pattern they | |||
| * overwrite each other. | |||
| */ | |||
| void setRealtimeVehicles(TripPattern pattern, List<RealtimeVehicle> updates); | |||
| void setRealtimeVehicles(String feedId, Multimap<TripPattern, RealtimeVehicle> updates); | |||
There was a problem hiding this comment.
Update javadoc, this no longer updates vehicles just for one pattern but rather for the whole feed? Perhaps also rename the method so it's clear what this updates.
There was a problem hiding this comment.
I've updated the Javadoc but I'm unsure what a better name is. Maybe setRealtimeVehiclesForFeed?
...ava/org/opentripplanner/service/realtimevehicles/internal/DefaultRealtimeVehicleService.java
Outdated
Show resolved
Hide resolved
...ava/org/opentripplanner/service/realtimevehicles/internal/DefaultRealtimeVehicleService.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/opentripplanner/updater/vehicle_position/RealtimeVehiclePatternMatcher.java
Show resolved
Hide resolved
leonardehrenfried
force-pushed
the
clear-positions
branch
from
13d29cf to
685d2ed
Compare
binh-dam-ibigroup
previously approved these changes
Mar 12, 2025
binh-dam-ibigroup
previously approved these changes
Mar 13, 2025
optionsome
reviewed
Mar 14, 2025
...on/src/main/java/org/opentripplanner/service/realtimevehicles/RealtimeVehicleRepository.java
Outdated
Show resolved
Hide resolved
optionsome
approved these changes
Mar 14, 2025
t2gran
pushed a commit
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The real time vehicle service does not correctly remove the data from the previous download which this PR fixes.
It introduces copy-on-write semantics for the service rather than explicit removal by the calling code, reducing the number of places where mutable state is handled.
It also adds a new GraphQL property so that the last update is now expressed as an ISO date time rather than number of seconds since the epoch.
Issue
n/a
Unit tests
Added.
Documentation
Javadoc
cc @whitneys-pm