-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix entrances being removed from walk steps #6530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6530 +/- ##
=============================================
+ Coverage 70.18% 70.27% +0.08%
- Complexity 18310 18393 +83
=============================================
Files 2082 2088 +6
Lines 77195 77416 +221
Branches 7827 7841 +14
=============================================
+ Hits 54177 54401 +224
+ Misses 20251 20246 -5
- Partials 2767 2769 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test in StatesToWalkStepsMapperTest
. You probably also have to update support for it in the TestStationBuilder
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes fix the entrance problems with HSL data.
Overall logic in this class is difficult to grasp, but I guess refactoring it all is not in the scope of this PR.
Summary
Prevents removing of walksteps with entrance information
Issue
Closes #6528
Unit tests
Write a few words on how the new code is tested.
Documentation
Changelog
The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add the label
skip changelog
to the PR.Bumping the serialization version id