Skip to content

Fix entrances being removed from walk steps #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 27, 2025

Conversation

HenrikSundell
Copy link
Contributor

@HenrikSundell HenrikSundell commented Mar 11, 2025

Summary

Prevents removing of walksteps with entrance information

Issue

Closes #6528

Unit tests

Write a few words on how the new code is tested.

Documentation

Changelog

The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add the label skip changelog to the PR.

Bumping the serialization version id

@HenrikSundell HenrikSundell requested a review from a team as a code owner March 11, 2025 07:40
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.27%. Comparing base (9807f18) to head (21dbabe).
Report is 243 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...ing/algorithm/mapping/StatesToWalkStepsMapper.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6530      +/-   ##
=============================================
+ Coverage      70.18%   70.27%   +0.08%     
- Complexity     18310    18393      +83     
=============================================
  Files           2082     2088       +6     
  Lines          77195    77416     +221     
  Branches        7827     7841      +14     
=============================================
+ Hits           54177    54401     +224     
+ Misses         20251    20246       -5     
- Partials        2767     2769       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test in StatesToWalkStepsMapperTest. You probably also have to update support for it in the TestStationBuilder.

@t2gran t2gran added this to the 2.8 (next release) milestone Mar 12, 2025
@leonardehrenfried leonardehrenfried changed the title Fix bug where entrances are removed from walk steps Fix entrances being removed from walk steps Mar 12, 2025
Copy link
Contributor

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes fix the entrance problems with HSL data.

Overall logic in this class is difficult to grasp, but I guess refactoring it all is not in the scope of this PR.

@vesameskanen vesameskanen merged commit 0c9dab0 into opentripplanner:dev-2.x Mar 27, 2025
6 checks passed
@vesameskanen vesameskanen deleted the entrance-bug branch March 27, 2025 08:24
t2gran pushed a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Station entrances get removed from Walk Steps
4 participants