Fix itinerary cost review

[t2gran]

Summary

Small fixes suggest in the review of #6535.

Renaming ItineraryFares to ItineraryFares is debatable:

• In old Java conventions plural is used for naming variables and classes witch are of collection type, not necesseraly extending the java collections, but something containing a collection of the singular form.
• Note that ItineraryFare is related to the itinerary, it does contain a collection of fares for legs - but only one fare for the total Itinerary.

Alternative name: ItineraryFareInfo

Issue

🟥 This is code cleanup

Unit tests

🟥 No new functional changes

Documentation

✅ JavaDoc is updated

Changelog

🟥 This is code cleanup

Bumping the serialization version id

🟥 No changes to serialized classes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.23%. Comparing base (52dc65f) to head (fa6efcb).
Report is 85 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6539      +/-   ##
=============================================
- Coverage      70.24%   70.23%   -0.01%     
+ Complexity     18369    18362       -7     
=============================================
  Files           2087     2087              
  Lines          77381    77377       -4     
  Branches        7839     7839              
=============================================
- Hits           54357    54347      -10     
- Misses         20249    20252       +3     
- Partials        2775     2778       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[leonardehrenfried]

You say that it doesn't contain several fares for the itinerary which is not true:

OpenTripPlanner/application/src/main/java/org/opentripplanner/model/fare/ItineraryFares.java

Line 27 in e8e9a77

private final Set<FareProduct> itineraryProducts = new LinkedHashSet<>();

[leonardehrenfried]

Can you cherry-pick (not merge) this commit to re-enable the fares tests: leonardehrenfried@61eab43

[t2gran]

You say that it doesn't contain several fares for the itinerary which is not true

Correct me if I am wrong! But, it is relative to the itinerary - it contains many fars for LEGS, but only one option for the itinerary - it is not a collection of itinerary fares - as the name literally suggest.

[leonardehrenfried]

There can also be several options for the entire itinerary. For example you can buy a weekly or a monthly ticket, which both cover the entire itinerary.

[t2gran]

Can you cherry-pick (not merge) this commit to re-enable the fares tests: leonardehrenfried@61eab43

I already did that in the original PR: f46d68a

[leonardehrenfried]

Ah, sorry, I missed that.

[t2gran]

There can also be several options for the entire itinerary. For example you can buy a weekly or a monthly ticket, which both cover the entire itinerary.

Ok, I kind of suspected that could be the case, but it is still not a collection of "itinerary fares". I can agree this is a boarder case - but the key thing here is OOP thinking - and not about correct english.

[leonardehrenfried]

There can also be several options for the entire itinerary. For example you can buy a weekly or a monthly ticket, which both cover the entire itinerary.

Ok, I kind of suspected that could be the case, but it is still not a collection of "itinerary fares". I can agree this is a boarder case - but the key thing here is OOP thinking - and not about correct english.

To be honest, I don't really care all that much what it is called and will follow your suggestion.