Use locale param if one is defined over accept-language header in GTFS APIs #6552
+109
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6552 +/- ##
=============================================
- Coverage 70.25% 70.24% -0.01%
+ Complexity 18387 18381 -6
=============================================
Files 2088 2088
Lines 77425 77410 -15
Branches 7843 7840 -3
=============================================
- Hits 54395 54377 -18
- Misses 20258 20264 +6
+ Partials 2772 2769 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| return userLocale; | ||
| var envLocale = environment.getLocale(); |
There was a problem hiding this comment.
Just a question about names:
- localContextLocale is the one passed in the GraphQL query body
- env Locale is passed the one from the HTTP header
Accept-Language
Correct?
If so, can you write a few lines in this class? It would help me understand what is going on.
There was a problem hiding this comment.
There is some comments in this method that explain this. But I'll clarify the comments a bit and add javadoc to methods.
leonardehrenfried
requested changes
Mar 21, 2025
leonardehrenfried
approved these changes
Mar 21, 2025
vpaturet
approved these changes
Mar 24, 2025
t2gran
pushed a commit
that referenced
this pull request
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously if both accept-language header and locale param were defined, env would be used. This changes the prioritization so that the locale param is used.
Issue
No issue
Unit tests
Update tests
Documentation
Not needed
Changelog
From title