Skip to content

Fix NPE in RoutingWorker after #6535 was merged #6562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Mar 20, 2025

Summary

We get a NullPointerException for via search after #6535 was merged. One return statement was missed when converting to use Result DTO in RoutingWorker.

Issue

🟥 There is no issue.

Unit tests

🟥 We do not have integration test on this - we probably should.

Documentation

🟥 This is a regression, no feature changes.

Changelog

🟥 The PR #6535 is in the same version as this.

Bumping the serialization version id

🟥 Not needed, no changes to model.

@t2gran t2gran added this to the 2.8 (next release) milestone Mar 20, 2025
@t2gran t2gran requested a review from a team as a code owner March 20, 2025 09:29
@t2gran t2gran added the Entur Test This is currently being tested at Entur label Mar 20, 2025
@vpaturet vpaturet self-requested a review March 20, 2025 09:33
@t2gran t2gran changed the title fix: Fix NPE in RoutingWorker after #6535 was merged Fix NPE in RoutingWorker after #6535 was merged Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.24%. Comparing base (9f6be97) to head (e780290).
Report is 11 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...entripplanner/routing/algorithm/RoutingWorker.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6562   +/-   ##
==========================================
  Coverage      70.24%   70.24%           
- Complexity     18381    18382    +1     
==========================================
  Files           2088     2088           
  Lines          77417    77417           
  Branches        7840     7840           
==========================================
  Hits           54380    54380           
  Misses         20265    20265           
  Partials        2772     2772           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t2gran t2gran merged commit 38a90ca into opentripplanner:dev-2.x Mar 20, 2025
6 checks passed
@t2gran t2gran deleted the fix_via_results branch March 20, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Entur Test This is currently being tested at Entur Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants