-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix: Skip new ser-ver-id for --release option (custom-release) #6683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
t2gran
wants to merge
11
commits into
opentripplanner:dev-2.x
Choose a base branch
from
entur:fix_release_script
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6683 +/- ##
=============================================
+ Coverage 71.40% 71.58% +0.17%
- Complexity 18569 18932 +363
=============================================
Files 2035 2059 +24
Lines 76553 77467 +914
Branches 7824 7900 +76
=============================================
+ Hits 54664 55454 +790
- Misses 19116 19198 +82
- Partials 2773 2815 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dfe4fa0
to
10babda
Compare
6559f84
to
d64ce47
Compare
d64ce47
to
88f4f8e
Compare
tkalvas
requested changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improve the
custom_release.py
with enhanced logic on setting the correctserialization.version.id
. The new logic work as follows:The terms "current release" and "new release" was slightly misleading. I changed them to:
latest release
(wascurrent release
). The last tagged release.next release
(wasnew release
) . The new release to be created next. Current is still used to refer to the current content of e.g. pom.xml - next refer to the what the value will be after the release is made.In addition to these terms the
base release
is used to refer to the release used as the starting point for the next release - witch might be the latest release, but could be any commit.Issue
🟥 There is no issue for this.
Unit tests
🟥 There are no tests on the custom release script.
Documentation
✅ The doc is updated.
Changelog
🟥 This is to technical and minor to end up in the release notes.
Bumping the serialization version id
🟥 Does not have any effect on OTP at all.