Add NVTX events in triggered task start/finish #1133
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikryukov
reviewed
May 12, 2025
Collaborator
ikryukov
left a comment
ikryukov
left a comment
There was a problem hiding this comment.
I believe it should be hidden behind an ifdef statement and guarded by a define or profile build. This approach will prevent performance regressions and simplify the build process.
Collaborator
|
@x41lakazam @lappazos This is not the correct approach, we cannot introduce a dependency directly in core files. Need to think how to integrate it within the existing profiler. @ikryukov @Sergei-Lebedev for viz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.