TOOLS: perftest add matrix generator #1220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaeliyac
force-pushed
the
pt_generator_add_matrix_generator_a2av
branch
2 times, most recently
from
395e944 to
81d74f2
Compare
Greptile Overview
|
| Filename | Score | Overview |
|---|---|---|
| tools/perf/generator/ucc_pt_generator_traffic_matrix.cc | 2/5 | New traffic matrix generator with critical division-by-zero bug in bias probability calculation (line 86) |
| tools/perf/ucc_pt_config.cc | 4/5 | Adds command-line parsing for matrix generator and seed parameter with proper error handling |
| tools/perf/ucc_pt_benchmark.cc | 5/5 | Integrates matrix generator with proper type checking for ALLTOALLV operations |
yaeliyac
force-pushed
the
pt_generator_add_matrix_generator_a2av
branch
from
3ad787f to
08bac56
Compare
yaeliyac
force-pushed
the
pt_generator_add_matrix_generator_a2av
branch
4 times, most recently
from
849964b to
746b197
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| size_t ucc_pt_generator_traffic_matrix::get_count_max() | ||
| { | ||
| auto matrix = pattern_counts[current_pattern]; |
There was a problem hiding this comment.
style: copying entire vector instead of using const reference, causes unnecessary memory allocation
ikryukov
suggested changes
Nov 27, 2025
Collaborator
ikryukov
left a comment
ikryukov
left a comment
There was a problem hiding this comment.
Please, use clang format file from repo to format code
| #include <numeric> | ||
| #include <stdexcept> | ||
|
|
||
| std::default_random_engine generator; |
Collaborator
There was a problem hiding this comment.
can we avoid global variables?
yaeliyac
force-pushed
the
pt_generator_add_matrix_generator_a2av
branch
from
746b197 to
867fb69
Compare
| probabilities[bias_index] *= bias_factor; | ||
| } | ||
| } | ||
| int sum = std::accumulate(probabilities.begin(), probabilities.end(), 0); |
There was a problem hiding this comment.
logic: integer accumulator truncates doubles to 0, causing division by zero on line 88
Suggested change
| int sum = std::accumulate(probabilities.begin(), probabilities.end(), 0); | |
| double sum = std::accumulate(probabilities.begin(), probabilities.end(), 0.0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Matrix generator option to pt generator for A2AV matrices.
This PR adds matrix creation based on this repo
4 kinds of matrices -
0. Basic A2AV (uniform traffic)
run with --gen matrix:kind={0-3}@token_size_KB_mean=N@num_tokens=M@tgt_group_size_mean=K
token_size_KB_mean, num_tokens, tgt_group_size_mean will get default values if not set.