Skip to content

UCP/CORE: Return an error if there is no modifiable configuration. #11003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

UCP/CORE: Return an error if there is no modifiable configuration. #11003

wants to merge 10 commits into from

Conversation

@rakhmets
Copy link
Contributor

@rakhmets rakhmets commented Nov 11, 2025 •
edited
Loading

What?

ucp_config_modify returns an error if there is no modifiable configuration matching the passed name.

Why?

Previously ucp_config_modify saved the option and issued a warning only after a UCP worker creation. So the caller had no indication of the success of the method call.

How?

Calling uct_query_components method fills in ucs_config_global_list list. This list is used to check the presence of an option.

@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025 •
edited
Loading

Walkthrough

Added a context config flag to enable/disable warnings for unused configuration modifications; renamed and refactored the unused-config warning routine (early-exit, pluralized message, renames) and its caller; added unit tests to validate warning emission and suppression; adjusted test logger filtering logic.

Changes

Cohort / File(s) Change Summary
Context configuration
src/ucp/core/ucp_context.c, src/ucp/core/ucp_context.h		 Added warn_unused_config_modifications field to ucp_context_config_t and UCP_WARN_UNUSED_CONFIG_MODIFICATIONS config entry (bool flag, default enabled) in the context config table; introduced mapping/macro for the new option.
Worker warning / message refactor
src/ucp/core/ucp_worker.c		 Renamed ucp_warn_unused_uct_config → ucp_warn_unused_config_modifications; added early-exit guard reading context->config.ext.warn_unused_config_modifications; switched to const iterator over context->cached_key_list; renamed message buffer/counter (unused_cached_uct_cfg → unused_modifications, num_unused_kv → num_unused_modifications); updated message text (pluralization and suppression hint), trimming and cleanup; updated caller in ucp_worker_create.
Unit tests — new tests
test/gtest/ucp/test_ucp_context.cc		 Added test_unused_config_modifications test class that modifies UCP config in its ctor; added tests wrap_warning (expects warnings) and hide_warning (disables WARN_UNUSED_CONFIG_MODIFICATIONS and expects no warning); instantiated for TLS self.
Unit tests — logger filter change
test/gtest/ucp/ucp_test.cc		 Modified hide_config_warns_logger logic: previously filtered based on substring "invalid configuration", now requires messages to match both "unused configurations" and "UCX_WARN_UNUSED_CONFIG_MODIFICATIONS" to be treated the same way (adjusts suppression/continuation behavior).

Sequence Diagram(s)

sequenceDiagram
  participant App as Application
  participant UCP as ucp_worker_create
  participant Ctx as ucp_context_t
  participant Warn as ucp_warn_unused_config_modifications
  Note over App,UCP: Application requests worker creation
  App->>UCP: call ucp_worker_create()
  UCP->>Ctx: access context->config
  UCP->>Warn: call ucp_warn_unused_config_modifications(context)
  Warn->>Ctx: read context->config.ext.warn_unused_config_modifications
  alt enabled
    Warn->>Ctx: iterate context->cached_key_list
    Warn->>Warn: build `unused_modifications` message (pluralize, suppression hint)
    Warn-->>UCP: emit diagnostic/warning
  else disabled
    Warn-->>UCP: return (no warning)
  end
  UCP-->>App: worker created
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Pay extra attention to:
    • Early-exit guard and correct field access in ucp_worker.c.
    • Message formatting (pluralization, suppression hint), buffer trimming and free.
    • Config table entry correctness and default value in ucp_context.c/.h.
    • Test changes: new tests in test_ucp_context.cc and modified logger filter in test/gtest/ucp/ucp_test.cc.

Poem

🐇 I hopped through keys at morning light,

found unused whispers tucked away from sight.
I nudged a flag, I changed the tone —
now warnings sing or hush, as you own.
Carrots for tidy configs and delight. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding optional warnings about unused configuration modifications. It directly relates to the primary objective of the PR.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yosefe
Copy link
Contributor

yosefe commented Nov 16, 2025

@rakhmets why do we want to hide it by default?

@rakhmets rakhmets marked this pull request as draft November 18, 2025 09:05
@rakhmets rakhmets force-pushed the topic/unused-cfg-log-level branch 2 times, most recently from f4fe5a4 to 05f5b40 Compare November 21, 2025 15:29
@rakhmets rakhmets force-pushed the topic/unused-cfg-log-level branch from 05f5b40 to 9b13ceb Compare November 21, 2025 15:34
@rakhmets rakhmets changed the title UCP/CORE: Changed logging for unused configuration modifications. UCP/CORE: Optional warnings about unused config modifications. Nov 21, 2025
@rakhmets
Copy link
Contributor Author

rakhmets commented Nov 21, 2025

@rakhmets why do we want to hide it by default?

Re-worked.
The warning is issued by default.

@rakhmets rakhmets marked this pull request as ready for review November 21, 2025 15:48
coderabbitai[bot]
coderabbitai bot reviewed Nov 21, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
test/gtest/ucp/test_ucp_context.cc (1)

122-130: Consider enhancing test coverage.

The test verifies that the warning can be suppressed, but it doesn't explicitly validate:

  1. That a warning is emitted when WARN_UNUSED_CONFIG_MODIFICATIONS=y (default)
  2. That the warning message format is correct

Consider adding a test case that expects the warning to be emitted when the flag is enabled.

Example enhancement:

class test_unused_config_modifications : public test_ucp_context {
public:
    test_unused_config_modifications() {
        ucp_config_modify(m_ucp_config, "QWERTY", "QWERTY");
    }
};

UCS_TEST_P(test_unused_config_modifications, warning_shown) {
    // Should emit warning with default config
    size_t warn_count = m_warnings.size();
    create_entity();
    EXPECT_GT(m_warnings.size(), warn_count);
}

UCS_TEST_P(test_unused_config_modifications, warning_hidden) {
    // Should not emit warning when disabled
    ucp_config_modify(m_ucp_config, "WARN_UNUSED_CONFIG_MODIFICATIONS", "n");
    size_t warn_count = m_warnings.size();
    create_entity();
    EXPECT_EQ(m_warnings.size(), warn_count);
}
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51b344f and 9b13ceb.

📒 Files selected for processing (4)
  • src/ucp/core/ucp_context.c (1 hunks)
  • src/ucp/core/ucp_context.h (2 hunks)
  • src/ucp/core/ucp_worker.c (2 hunks)
  • test/gtest/ucp/test_ucp_context.cc (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/ucp/core/ucp_worker.c
🧰 Additional context used
🧬 Code graph analysis (1)
test/gtest/ucp/test_ucp_context.cc (1)
src/ucp/core/ucp_context.c (1)
  • ucp_config_modify (871-887)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (870)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 2)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Server)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 1)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java11)
  • GitHub Check: UCX PR (AddressSanitizer roce on worker 0)
  • GitHub Check: UCX PR (ucx_perftest over MAD RTE Setup Client)
  • GitHub Check: UCX PR (jucx JUCX Test aarch64 java8)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 3)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java11)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 3)
  • GitHub Check: UCX PR (go gpu)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 2)
  • GitHub Check: UCX PR (jucx JUCX Test amd64 java8)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 2)
  • GitHub Check: UCX PR (Tests BlueField on worker 3)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 1)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 1)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu1804)
  • GitHub Check: UCX PR (AddressSanitizer BlueField on worker 0)
  • GitHub Check: UCX PR (Tests BlueField on worker 2)
  • GitHub Check: UCX PR (AddressSanitizer new on worker 0)
  • GitHub Check: UCX PR (AddressSanitizer gpu on worker 0)
  • GitHub Check: UCX PR (Build_Static build_source ubuntu2004)
  • GitHub Check: UCX PR (Tests BlueField on worker 1)
  • GitHub Check: UCX PR (go new)
  • GitHub Check: UCX PR (Tests roce on worker 3)
  • GitHub Check: UCX PR (Build_Static build_source centos7)
  • GitHub Check: UCX PR (Tests new on worker 3)
  • GitHub Check: UCX PR (Tests BlueField on worker 0)
  • GitHub Check: UCX PR (Cuda Create UCX source tarball)
  • GitHub Check: UCX PR (Tests roce on worker 2)
  • GitHub Check: UCX PR (Tests new on worker 2)
  • GitHub Check: UCX PR (Tests althca on worker 3)
  • GitHub Check: UCX PR (Namespace_Tests new_namespace on worker)
  • GitHub Check: UCX PR (Tests gpu on worker 3)
  • GitHub Check: UCX PR (Tests roce on worker 1)
  • GitHub Check: UCX PR (Tests new on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 2)
  • GitHub Check: UCX PR (Tests gpu on worker 2)
  • GitHub Check: UCX PR (EFA_Tests EFA on rhel90_ib)
  • GitHub Check: UCX PR (Tests roce on worker 0)
  • GitHub Check: UCX PR (Tests new on worker 0)
  • GitHub Check: UCX PR (Tests althca on worker 1)
  • GitHub Check: UCX PR (Tests gpu on worker 1)
  • GitHub Check: UCX PR (Tests althca on worker 0)
  • GitHub Check: UCX PR (Tests gpu on worker 0)
  • GitHub Check: UCX PR (WireCompat Build on althca)
  • GitHub Check: UCX PR (WireCompat Build on gpu)
  • GitHub Check: UCX PR (WireCompat Build on new)
  • GitHub Check: UCX PR (Build build_x86_64 euleros2sp12)
  • GitHub Check: UCX PR (Build build_x86_64 kylin10sp3)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004_rocm)
  • GitHub Check: UCX PR (Build build_x86_64 centos10stream)
  • GitHub Check: UCX PR (Build build_x86_64 centos7)
  • GitHub Check: UCX PR (Build build_x86_64 fedora41)
  • GitHub Check: UCX PR (Build build_x86_64 rocky96)
  • GitHub Check: UCX PR (Build build_x86_64 rocky89)
  • GitHub Check: UCX PR (Build build_x86_64 rhel100)
  • GitHub Check: UCX PR (Build build_x86_64 rhel90)
  • GitHub Check: UCX PR (Build build_x86_64 rhel82)
  • GitHub Check: UCX PR (Build build_x86_64 sles15sp6)
  • GitHub Check: UCX PR (Build build_x86_64 debian130)
  • GitHub Check: UCX PR (Build build_x86_64 debian125)
  • GitHub Check: UCX PR (Build build_x86_64 debian109)
  • GitHub Check: UCX PR (Build build_x86_64 debian113)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2210)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2404)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2204)
  • GitHub Check: UCX PR (Build build_aarch64 rocky96_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu1804)
  • GitHub Check: UCX PR (Build build_aarch64 rocky89_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 ubuntu2004)
  • GitHub Check: UCX PR (Build build_aarch64 rhel100_aarch64)
  • GitHub Check: UCX PR (Build build_x86_64 rhel76)
  • GitHub Check: UCX PR (Coverity coverity release on coverity_rh7)
  • GitHub Check: UCX PR (Build build_aarch64 ubuntu2404_aarch64)
  • GitHub Check: UCX PR (Coverity coverity devel on coverity_rh7)
  • GitHub Check: UCX PR (Static_check Static checks)
  • GitHub Check: UCX PR (Codestyle ctags check)
  • GitHub Check: UCX PR (Codestyle AUTHORS file update check)
  • GitHub Check: UCX PR (Codestyle format code)
  • GitHub Check: UCX PR (Codestyle commit title)
🔇 Additional comments (4)
src/ucp/core/ucp_context.h (2)

224-225: LGTM!

The new configuration field is properly placed at the end of the struct and follows the existing convention of using int for boolean configuration values.

599-599: LGTM!

The macro definition follows the UCP naming convention and provides a clear constant for the configuration key.

src/ucp/core/ucp_context.c (1)

595-598: LGTM!

The configuration entry is properly defined with:

  • Default value "y" (warnings enabled by default, matching PR objectives)
  • Clear description
  • Correct field mapping
test/gtest/ucp/test_ucp_context.cc (1)

136-136: LGTM!

Using the "self" transport for this configuration test is appropriate.

@rakhmets rakhmets requested a review from brminich November 21, 2025 16:37
coderabbitai[bot]
coderabbitai bot reviewed Nov 21, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between abb595e and d0686cc.

📒 Files selected for processing (1)
  • test/gtest/ucp/ucp_test.cc (1 hunks)

@yosefe
Copy link
Contributor

yosefe commented Nov 23, 2025

@rakhmets why do we want to hide it by default?

Re-worked. The warning is issued by default.

I probably misunderstood the PR. IMO the behavior should be:
For env var configs - warn by default, could be disabled by UCX_WARN_UNUSED_ENV_VARS
For ucp_config_modify - no warning - the indication is from API return value. Application can warn if it wants.

@rakhmets
Copy link
Contributor Author

rakhmets commented Nov 24, 2025

@rakhmets why do we want to hide it by default?

Re-worked. The warning is issued by default.

I probably misunderstood the PR. IMO the behavior should be: For env var configs - warn by default, could be disabled by UCX_WARN_UNUSED_ENV_VARS For ucp_config_modify - no warning - the indication is from API return value. Application can warn if it wants.

The problem is that at the stage of calling ucp_config_modify we still do not know which of the options are available at the UCT level. ucp_config_modify returns UCS_OK if the passed option is not found at the UCP level, and saves it for future use. UCX issues a warning if the saved options have not been applied after creating the worker.

@rakhmets rakhmets marked this pull request as draft November 28, 2025 12:48
@rakhmets rakhmets changed the title UCP/CORE: Optional warnings about unused config modifications. UCP/CORE: Return an error if there is no modifiable configuration. Nov 28, 2025
@rakhmets rakhmets force-pushed the topic/unused-cfg-log-level branch from afc1d61 to 8cac639 Compare November 28, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brminich brminich Awaiting requested review from brminich

1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rakhmets @yosefe