-
Notifications
You must be signed in to change notification settings - Fork 497
Added Intel Gaudi GDR support for UCX #11017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zzhang37
wants to merge
1
commit into
openucx:master
Choose a base branch
from
intel-staging:intel_gaudi_gdr_enabling_0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,9 +15,12 @@ Artem Ryabov <[email protected]> | |
| Artemy Kovalyov <[email protected]> | ||
| Arun Chandran <[email protected]> | ||
| Aurelien Bouteiller <[email protected]> | ||
| Benson Muite <[email protected]> | ||
| Bin Lei <[email protected]> | ||
| Boris Karasev <[email protected]> | ||
| Brad Benton <[email protected]> | ||
| Brian Sheng <[email protected]> | ||
| Bruno Faccini <[email protected]> | ||
| Changcheng Liu <[email protected]> | ||
| Colin Hirsch <[email protected]> | ||
| Corey J. Nolet <[email protected]> | ||
|
|
@@ -29,17 +32,20 @@ Dmitrii Gabor <[email protected]> | |
| Dmitry Gladkov <[email protected]> | ||
| Doug Jacobsen <[email protected]> | ||
| Edgar Gabriel <[email protected]> | ||
| Elad Guttel <[email protected]> | ||
| Elad Persiko <[email protected]> | ||
| Eugene Voronov <[email protected]> | ||
| Evgeny Leksikov <[email protected]> | ||
| Fabian Ruhland <[email protected]> | ||
| Felix Abecassis <[email protected]> | ||
| Gilbert Lee <[email protected]> | ||
| Gilles Gouaillardet <[email protected]> | ||
| Gonzalo Brito Gadeschi <[email protected]> | ||
| Graham Lopez <[email protected]> | ||
| Guy Shattah <[email protected]> | ||
| Hessam Mirsadeghi <[email protected]> | ||
| Hiroyuki Sato <[email protected]> | ||
| Honggang Li <[email protected]> | ||
| Howard Pritchard <[email protected]> | ||
| Huaxiang Fan <[email protected]> | ||
| Hui Zhou <[email protected]> | ||
|
|
@@ -48,13 +54,16 @@ Ilia Yastrebov <[email protected]> | |
| Ilya Nelkenbaum <[email protected]> | ||
| Itay Alroy <[email protected]> | ||
| Ivan Kochin <[email protected]> | ||
| JKLiang9714 <[email protected]> | ||
| Jakir Kham <[email protected]> | ||
| Jan Ciesko <[email protected]> | ||
| Jason Gunthorpe <[email protected]> | ||
| Jeff Daily <[email protected]> | ||
| Jianxin Xiong <[email protected]> | ||
| John Snyder <[email protected]> | ||
| Jonas Zhou <[email protected]> | ||
| Joseph Schuchart <[email protected]> | ||
| Kaidrikov Evgeny <[email protected]> | ||
| Keisuke Fukuda <[email protected]> | ||
| Ken Raffenetti <[email protected]> | ||
| Khaled Hamidouche <[email protected]> | ||
|
|
@@ -66,33 +75,40 @@ Manjunath Gorentla Venkata <[email protected]> | |
| Marek Schimara <[email protected]> | ||
| Mark Allen <[email protected]> | ||
| Matthew Baker <[email protected]> | ||
| Matthias Diener <[email protected]> | ||
| Michael Braverman <[email protected]> | ||
| Michal Shalev <[email protected]> | ||
| Mike Dubman <[email protected]> | ||
| Mikhail Brinskii <[email protected]> | ||
| Mikhail Brinskiy <[email protected]> | ||
| Min Fang <[email protected]> | ||
| Nathan Hjelm <[email protected]> | ||
| Netanel Yosephian <[email protected]> | ||
| Nysal Jan K.A <[email protected]> | ||
| Ofir Farjon <[email protected]> | ||
| Olly Perks <[email protected]> | ||
| Ovidiu Mara <[email protected]> | ||
| Pak Lui <[email protected]> | ||
| Pasha (Pavel) Shamis <[email protected]> | ||
| Pavan Balaji <[email protected]> | ||
| Pavel Shamis (Pasha) <[email protected]> | ||
| Peter Andreas Entschev <[email protected]> | ||
| Peter Rudenko <[email protected]> | ||
| Peter-Jan Gootzen <[email protected]> | ||
| Qiang Yu <[email protected]> | ||
| Raul Akhmetshin <[email protected]> | ||
| Rob Bradford <[email protected]> | ||
| Robert Dietrich <[email protected]> | ||
| Rohit Zambre <[email protected]> | ||
| Roie Danino <[email protected]> | ||
| Romain Pereira <[email protected]> | ||
| Sam James <[email protected]> | ||
| Saravanan Vajravel <[email protected]> | ||
| Sasha Kotchubievsky <[email protected]> | ||
| Scott Saulters <[email protected]> | ||
| Sergey Lebedev <[email protected]> | ||
| Sergey Oblomov <[email protected]> | ||
| Sergey Oblomov [email protected] () <[email protected]> | ||
| Sergey Shalnov <[email protected]> | ||
| Serguei Sagalovitch <[email protected]> | ||
| Shachar Hasson <[email protected]> | ||
|
|
@@ -104,17 +120,32 @@ Stephen Richmond <[email protected]> | |
| Swen Boehm <[email protected]> | ||
| Thomas Vegas <[email protected]> | ||
| Tony Curtis <[email protected]> | ||
| Tooraj Taraz <[email protected]> | ||
| Tzafrir Cohen <[email protected]> | ||
| Valentin Petrov <[email protected]> | ||
| Vasily Philipov <[email protected]> | ||
| Wenbin Lu <[email protected]> | ||
| Xiang Gao <[email protected]> | ||
| Xin Zhao <[email protected]> | ||
| Xu Yifeng <[email protected]> | ||
| Yiltan Hassan Temucin <[email protected]> | ||
| Yossi Itigin <[email protected]> | ||
| Yuriy Shestakov <[email protected]> | ||
| Zhongkai Zhang <[email protected]> | ||
| Zhu Yanjun <[email protected]> | ||
| Zihao Zhao <[email protected]> | ||
| akolliasAMD <[email protected]> | ||
| akshay-venkatesh <[email protected]> | ||
| chenyidu <[email protected]> | ||
| dmitrygx <[email protected]> | ||
| esoha-nvidia <[email protected]> | ||
| lyu <[email protected]> | ||
| lzhang2 <[email protected]> | ||
| nileshnegi <[email protected]> | ||
| panda1100 <[email protected]> | ||
| razor1991 <[email protected]> | ||
| root <[email protected]> | ||
| shasson5 <[email protected]> | ||
|
|
||
| In addition we would like to acknowledge the following members of UCX community | ||
| for their participation in annual face-to-face meeting, design discussions, and | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| # | ||
| # Copyright (c) Intel Corporation, 2025. ALL RIGHTS RESERVED. | ||
| # See file LICENSE for terms. | ||
| # | ||
|
|
||
| AC_DEFUN([UCX_CHECK_GAUDI],[ | ||
|
|
||
| AS_IF([test "x$gaudi_checked" != "xyes"], | ||
| [ | ||
| AC_ARG_WITH([gaudi], | ||
| [AS_HELP_STRING([--with-gaudi=(DIR)], [Enable the use of GAUDI (default is guess).])], | ||
| [], [with_gaudi=guess]) | ||
|
|
||
| AS_IF([test "x$with_gaudi" = "xno"], | ||
| [ | ||
| gaudi_happy="no" | ||
| ], | ||
| [ | ||
| save_CPPFLAGS="$CPPFLAGS" | ||
| save_LDFLAGS="$LDFLAGS" | ||
| save_LIBS="$LIBS" | ||
|
|
||
| GAUDI_CPPFLAGS="" | ||
| GAUDI_LDFLAGS="" | ||
| GAUDI_LIBS="" | ||
|
|
||
| AS_IF([test ! -z "$with_gaudi" -a "x$with_gaudi" != "xyes" -a "x$with_gaudi" != "xguess"], | ||
| [ucx_check_gaudi_dir="$with_gaudi" | ||
| ucx_check_gaudi_libdir="$with_gaudi/lib/habanalabs" | ||
| GAUDI_CPPFLAGS="-I$with_gaudi/include/habanalabs -I/usr/include/drm -I/usr/include/libdrm" | ||
| GAUDI_LDFLAGS="-L$ucx_check_gaudi_libdir"], | ||
| [GAUDI_CPPFLAGS="-I/usr/include/habanalabs -I/usr/include/drm -I/usr/include/libdrm" | ||
| GAUDI_LDFLAGS="-L/usr/lib/habanalabs"]) | ||
|
|
||
| AS_IF([test ! -z "$with_gaudi_libdir" -a "x$with_gaudi_libdir" != "xyes"], | ||
| [ucx_check_gaudi_libdir="$with_gaudi_libdir" | ||
| GAUDI_LDFLAGS="-L$ucx_check_gaudi_libdir"]) | ||
|
|
||
| CPPFLAGS="$CPPFLAGS $GAUDI_CPPFLAGS" | ||
| LDFLAGS="$LDFLAGS $GAUDI_LDFLAGS" | ||
|
|
||
| # Check gaudi header files | ||
| AC_CHECK_HEADERS([hlthunk.h], | ||
| [gaudi_happy="yes"], [gaudi_happy="no"]) | ||
|
|
||
| # Check gaudi libraries | ||
| AS_IF([test "x$gaudi_happy" = "xyes"], | ||
| [AC_CHECK_LIB([hl-thunk], [hlthunk_open], | ||
| [GAUDI_LIBS="$GAUDI_LIBS -lhl-thunk -lscal -lSynapse -lSynapseMme"], [gaudi_happy="no"])]) | ||
|
|
||
| CPPFLAGS="$save_CPPFLAGS" | ||
| LDFLAGS="$save_LDFLAGS" | ||
| LIBS="$save_LIBS" | ||
|
|
||
| AS_IF([test "x$gaudi_happy" = "xyes"], | ||
| [AC_SUBST([GAUDI_CPPFLAGS], ["$GAUDI_CPPFLAGS"]) | ||
| AC_SUBST([GAUDI_LDFLAGS], ["$GAUDI_LDFLAGS"]) | ||
| AC_SUBST([GAUDI_LIBS], ["$GAUDI_LIBS"]) | ||
| AC_DEFINE([HAVE_GAUDI], 1, [Enable GAUDI support])], | ||
| [AS_IF([test "x$with_gaudi" != "xguess"], | ||
| [AC_MSG_ERROR([GAUDI support is requested but gaudi packages cannot be found])], | ||
| [AC_MSG_WARN([GAUDI not found])])]) | ||
|
|
||
| ]) # "x$with_gaudi" = "xno" | ||
|
|
||
| gaudi_checked=yes | ||
| AM_CONDITIONAL([HAVE_GAUDI], [test "x$gaudi_happy" != xno]) | ||
|
|
||
| ]) # "x$gaudi_checked" != "xyes" | ||
|
|
||
| ]) # UCX_CHECK_GAUDI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| usr/lib/ucx/libucx_perftest_gaudi.* | ||
| usr/lib/ucx/libuct_gaudi.* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like unrelated changes are added to the AUTHORS file