chore(switch): update swipe interaction docs #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After resolving openui#1045, this pull request removes the question and defines a swipe interaction with reference to the resolution.
gfellerph
requested review from
dbaron,
gregwhitworth and
mfreed7
as code owners
gregwhitworth
approved these changes
Sep 29, 2024
Member
gregwhitworth
left a comment
gregwhitworth
left a comment
There was a problem hiding this comment.
Left a minor request but approving with changes requested. Please close out the related issue upon merge.
|
|
||
| - Click/tap: toggles the switch | ||
| - <kbd>Spacebar</kbd>: toggles the switch which has keyboard focus | ||
| - Swipe: Switch should support gesture support akin to the range control ([#1045](https://github.com/openui/open-ui/issues/1045)) |
Member
There was a problem hiding this comment.
Can you please link to the MDN documentation of the range control?
tantek
requested changes
Oct 3, 2024
Collaborator
tantek
left a comment
tantek
left a comment
There was a problem hiding this comment.
Provided link to MDN per @gregwhitworth request.
Co-authored-by: Tantek Çelik <[email protected]>
gregwhitworth
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After resolving #1045, this pull request removes the question and defines a swipe interaction with reference to the resolution.