Rename focusgroup-entry-priority to focusgroupstart #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janewman
requested review from
dbaron,
gregwhitworth,
mfreed7 and
travisleithead
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rename was always coming, as focusgroup-entry-priority was both a mouthful and includes '-' which are not currently used for native attributes.
focusgroupstartwas chosen after reading a comment on the HTML spec draft, that said "... it isn't about priority but starting point."Other names have been suggested, see: #1314 (comment)
I'm flexible on the name here, and any of these would be fine with me if there was consensus.
Addresses #1314
This change also includes a pass to fix typos across the explainer.