Do not use SSE flags on arm64 platform #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@albarrentine please take a look when you have chance 🙏🏻 |
SiarheiFedartsou
commented
Dec 3, 2024
.github/workflows/test.yml
Outdated
| os: [ubuntu-latest, macos-latest] | ||
| os: | ||
| - ubuntu-latest | ||
| - macos-15-large # x86_64 |
Contributor
Author
There was a problem hiding this comment.
it is a bit confusing, but it is indeed how GH Actions define arm64 and x86_64 images :)
…t doing macos-latest which is arm64
Contributor
|
Hey @SiarheiFedartsou I just merged this today in node-postal which required targeting Do we possibly need to add that as an alias here too? |
Contributor
Author
hm, indeed, I think so, I tested only on macOS :) I'll create a fix nearest days. Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSE is not available on arm64, so the fact that we pass these flags causes compilation errors...