API to the language classifier #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Note: the pipeline is not passing because the project is missing an |
Contributor
|
@albarrentine Any thoughts on this PR? Adding support for the language classifier is a desireable feature for pypostal so that Python users can access this functionality (Since pypostal contains the official bindings). We've been using a fork for a time now, would be great to be able to use the official package again. Can confirm that this PR works on Mac OS 10.15.6. Small suggestion: add an example of the usage of the language classifier to the Readme. |
sbrugman
reviewed
Sep 4, 2020
| return NULL; | ||
| } | ||
|
|
||
| libpostal_language_classifier_response_t *response = libpostal_classify_language(input); |
Contributor
There was a problem hiding this comment.
language_classifier_response_t is defined above, but here we use libpostal_language_classifier_response_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to call the language classifier from libpostal (I made a PR in the libpostal repo as well to expose the functions needed for the method).
This functionality is very interesting given that it could be used as a feature for other types model.