New models in windows preparation script #3333
Conversation
mzegla
force-pushed
the
update_win_prepare_models
branch
from
7e567f4 to
7373f10
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds support for downloading tokenizers (with detokenizers) for new LLMs in the Windows preparation script and optimizes the existence check.
- Introduces four new model variables (QWEN3, LLAMA3, HERMES3, PHI4)
- Consolidates existence check into a single loop before per‐model download blocks
- Adds individual download logic for each new model
|
|
||
| set MODELS_LIST=%TEXT_GENERATION_MODEL% %EMBEDDING_MODEL% %EMBEDDING_MODEL%\ov %RERANK_MODEL% %VLM_MODEL% %QWEN3_MODEL% %LLAMA3_MODEL% %HERMES3_MODEL% %PHI4_MODEL% | ||
|
|
||
| set "ALL_EXIST=1" |
There was a problem hiding this comment.
The script uses delayed expansion markers (!ALL_EXIST!) in the loop but never enables delayed expansion. Add setlocal enabledelayedexpansion before the for loop so that ALL_EXIST is updated correctly.
Copilot uses AI. Check for mistakes.
| for %%M in (%MODELS_LIST%) do ( | ||
| if not exist "%~1\%%M" ( |
There was a problem hiding this comment.
Items in MODELS_LIST aren’t quoted, so any model path with spaces will break the loop. Either wrap each item in quotes when building MODELS_LIST or use for %%M in ("%MODELS_LIST%") to handle spaces safely.
| for %%M in (%MODELS_LIST%) do ( | |
| if not exist "%~1\%%M" ( | |
| for %%M in ("%MODELS_LIST%") do ( | |
| if not exist "%~1\%%~M" ( |
Copilot uses AI. Check for mistakes.
| @@ -93,4 +108,40 @@ if exist "%~1\%VLM_MODEL%" ( | |||
| if !errorlevel! neq 0 exit /b !errorlevel! | |||
| ) | |||
|
|
|||
| if exist "%~1\%QWEN3_MODEL%" ( | |||
There was a problem hiding this comment.
[nitpick] The individual download blocks for each model are nearly identical. Consider looping over the new model variables and calling a common download function to reduce duplication and simplify future additions.
Copilot uses AI. Check for mistakes.
No description provided.