Skip to content

[WIP] Use absl inline vector for Shape, Strides#28756

Closed
praasz wants to merge 9 commits intoopenvinotoolkit:masterfrom
praasz:poc/use-absl-inline-vector-for-type-based-on-vector
Closed

[WIP] Use absl inline vector for Shape, Strides#28756
praasz wants to merge 9 commits intoopenvinotoolkit:masterfrom
praasz:poc/use-absl-inline-vector-for-type-based-on-vector

Conversation

@praasz
Copy link
Contributor

@praasz praasz commented Jan 31, 2025

Details:

  • PR for test purposes to check usage of inlined_vector in shape, strides

Tickets:

praasz added 2 commits January 30, 2025 16:31
@praasz
Use custom vector type for small object like Shape, Strides, VectorDims
a00fae5 
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
@praasz
Use Abseil inlined_vector in openvino
9d71c6b 
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
@praasz praasz requested review from a team as code owners January 31, 2025 06:49
@praasz praasz requested review from kblaszczak-intel and mvafin and removed request for a team January 31, 2025 06:49
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: Python API OpenVINO Python bindings category: transformations OpenVINO Runtime library - Transformations category: LP transformations OpenVINO Low Precision transformations category: samples OpenVINO Runtime Samples category: IR FE OpenVINO IR v10 / v11 FrontEnd category: TEMPLATE OpenVINO Template plugin category: ONNX FE OpenVINO ONNX FrontEnd category: TF FE OpenVINO TensorFlow FrontEnd category: CPP API OpenVINO CPP API bindings category: PyTorch FE OpenVINO PyTorch Frontend category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: docs_snippets OpenVINO docs snippets (docs/snippets) category: NPU OpenVINO NPU plugin category: JAX FE OpenVINO JAX FrontEnd category: NPUW NPUW plugin labels Jan 31, 2025
@praasz praasz changed the title [POC][WIP] Use absl inline vector for Shape, Strides [WIP] Use absl inline vector for Shape, Strides Jan 31, 2025
@praasz
Remove not used allocator
827a2e6 
Signed-off-by: Raasz, Pawel <pawel.raasz@intel.com>
@maxnick maxnick self-assigned this Jan 31, 2025
@praasz praasz added the no_stale Do not mark as stale label Feb 7, 2025
pereanub
pereanub reviewed Feb 21, 2025
View reviewed changes
src/plugins/intel_npu/src/backend/src/zero_tensor.cpp
auto& shape = get_shape();
if (_strides.empty() && !shape.empty()) {
_strides.resize(shape.size());
_strides.resize(shape.size(), {});
Copy link
Contributor

@pereanub pereanub Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the same change to https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_npu/src/common/src/remote_tensor.cpp#L64 please?

Copy link
Contributor Author

@praasz praasz Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is draft for testing, so will apply it if solution will give some improvements

@mlukasze mlukasze requested a review from Copilot March 3, 2025 04:31
Copilot AI reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 256 out of 256 changed files in this pull request and generated no comments.

@praasz praasz closed this Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pereanub pereanub pereanub left review comments

Copilot code review Copilot Copilot left review comments

@kblaszczak-intel kblaszczak-intel Awaiting requested review from kblaszczak-intel kblaszczak-intel is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

@mvafin mvafin Awaiting requested review from mvafin mvafin is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov ilya-lavrenov is a code owner automatically assigned from openvinotoolkit/openvino-maintainers

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

Assignees

@maxnick maxnick

Labels

category: build OpenVINO cmake script / infra category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: docs_snippets OpenVINO docs snippets (docs/snippets) category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: IR FE OpenVINO IR v10 / v11 FrontEnd category: JAX FE OpenVINO JAX FrontEnd category: LP transformations OpenVINO Low Precision transformations category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin category: ONNX FE OpenVINO ONNX FrontEnd category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend category: samples OpenVINO Runtime Samples category: TEMPLATE OpenVINO Template plugin category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: transformations OpenVINO Runtime library - Transformations do_not_merge do_not_review no_stale Do not mark as stale WIP work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@praasz @pereanub @maxnick